Water temperature HUD in LocalCarData, AMS2 DSX/mapper support, DSX and ACC fixes#301
Water temperature HUD in LocalCarData, AMS2 DSX/mapper support, DSX and ACC fixes#301aaronfang wants to merge 7 commits intoRiddleTime:devfrom
Conversation
…temperatures from Kelvin to Celsius Made-with: Cursor
… and unit (Celsius/Fahrenheit) Made-with: Cursor
…round speed, fix acceleration unit conversion from m/s2 to G Made-with: Cursor
…quency helper, add InvertFrequency option for brake and throttle Made-with: Cursor
…ter, fix ACC averageRearTyreSlip operator precedence Made-with: Cursor
RiddleTime
left a comment
There was a problem hiding this comment.
Most looks good except some data modification that should happen within the data provider of AMS.
|
|
||
| float slipRatioFrontLeft, slipRatioFrontRight, slipRatioRearLeft, slipRatioRearRight; | ||
|
|
||
| if (useSignedSlip) |
There was a problem hiding this comment.
This should be within the data provider.
|
|
||
| float slipRatioFrontLeft, slipRatioFrontRight, slipRatioRearLeft, slipRatioRearRight; | ||
|
|
||
| if (useSignedSlip) |
There was a problem hiding this comment.
Same here, this should be within the data provider. Handle negative slip ratio values there.
… All slip ratios are now absolute values at the HUD layer
|
Thanks for the review! I've addressed both points: Changes made:
The signed slip handling is now properly contained within the AMS2 data provider, and the HUD layer no longer needs to know which games use signed vs unsigned slip ratios. Let me know if there's anything else that needs adjustment! |
What changed
Data and game adapters
New overlay
DSX
Files touched (high level)
Suggested checks for reviewers