Humble: MCAP storage 헤더 설치 보정 - #3
Open
hdh7485 wants to merge 2 commits into
Open
Conversation
hdh7485
marked this pull request as ready for review
August 11, 2026 18:14
sh-park-rf
reviewed
Aug 12, 2026
sh-park-rf
left a comment
sh-park-rf
left a comment
There was a problem hiding this comment.
rosbag2_transport쪽 수정은 필요하지 않을것 같습니다.
rosbag2_node가 있었던 이유는 generic pub/sub을 쓰기 위해서였는데 humble에서는 기본 노드에 이미 있기 때문에 rosbag2_node를 분리할 필요가 없을것 같습니다.
반대로 logging system쪽을 수정해야 할것 같아요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
Humble rosbag2에서 필요한 호환 헤더와 MCAP 헤더가 설치되도록 수정했습니다.
검증