Repository navigation
Conversation
GCC declares the immediate of _mm512_shuffle_epi32 as _MM_PERM_ENUM, and C++ does not convert an int to it, so the library failed to compile as C++ with GCC on x86-64. Pass _MM_PERM_BADC and _MM_PERM_CDAB, the named constants for 0x4E and 0xB1. The library does not compile as C++ under MSVC, which rejects C designated initializers before C++20 and C compound literals in any mode. Remove the Windows jobs until that is fixed, and rename the workflow to match the other Ubuntu-only workflows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anemitz
force-pushed
the
fix/c-tests-cpp
branch
from
October 31, 2026 03:08
fcda080 to
f9f8187
Compare
Contributor
Author
|
Perhaps the best course of action is to just remove these broken options since it's unclear if there's value in fixing this. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores
ROARING_BUILD_C_TESTS_AS_CPPandROARING_BUILD_C_AS_CPP, including the external C function definitions needed when C callers link against a C++-built library.Why care?
For it:
Against it:
Validation and implementation notes
_MM_PERM_ENUMerror first reached CI.container_iterator_nextandcontainer_iterator_prev.The C++ build emits 45 constant
croaring_inline_*pointer symbols as implementation details to retain callable inline definitions without compiler-specific retention flags. Static-inline helpers are not retained this way.