fix: implement validation URL to block XSS and invalid links - #1012
Merged
Spiral-Memory merged 1 commit intoSep 21, 2025
Merged
Conversation
Spiral-Memory
approved these changes
Aug 21, 2025
Collaborator
|
Thanks @Khizarshah01 for adding the URL validator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix: URL Validation in InsertLinkToolBox
Acceptance Criteria fulfillment
isUrlFixes #1010
#1011
Video/Screenshots
Given video in issue #1010
Technical Changes
validatorlib and useisUrlfunction that checks whether the URL is valid or not.PR Test Details
Test with:
javascript:alert(1),hello world)Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace
<pr_number>with the actual PR number.