fix: user info sidebar re-render - #1014
Merged
Merged
Conversation
|
|
Collaborator
|
Hi @ShashwatPS |
Contributor
Author
Done please have a look whenever you are free. |
Spiral-Memory
approved these changes
Nov 27, 2025
Spiral-Memory
left a comment
Spiral-Memory
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, Thanks @ShashwatPS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Title
If the user info sidebar is already open and I click on another avatar, the sidebar doesn’t update even though the user state is being updated. This happened because the useEffect dependency array didn’t include the user info change.
Video/Screenshots ( Fixed )
Screen.Recording.2025-10-08.at.6.35.56.AM.mov
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1014 after approval. Contributors are requested to replace
1014with the actual PR number.Related Issue: #1017