Skip to content

Fixed slash commands entered in threads displayed in main chat - #1042

Merged
Spiral-Memory merged 2 commits into
RocketChat:developfrom
Pratheek555:fix/Slash_commands_in_threads
Jan 15, 2026
Merged

Spiral-Memory merged 2 commits into
RocketChat:developfrom
Pratheek555:fix/Slash_commands_in_threads

Conversation

@Pratheek555

@Pratheek555 Pratheek555 commented Dec 16, 2025 •

Copy link
Copy Markdown
Contributor

Brief Title

Acceptance Criteria fulfillment

  • Preserve and forward the tmid (thread message ID) when sending slash command requests
  • Ensure the Rocket.Chat server response is rendered inside the originating thread
  • Prevent slash command responses from leaking into the main channel context

Fixes #1041

Video/Screenshots

image

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1042 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory

Copy link
Copy Markdown
Collaborator

Please resolve lint issues

@Pratheek555

Copy link
Copy Markdown
Contributor Author

Please resolve lint issues

I have resolved them :)

@Spiral-Memory Spiral-Memory left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Spiral-Memory

Copy link
Copy Markdown
Collaborator

Commands like /help are still not visible in threads, so it might be worth looking into. Lennyface is working perfectly now, thanks for the fix.

@Spiral-Memory
Spiral-Memory merged commit 4c3cfd1 into RocketChat:develop Jan 15, 2026
4 checks passed
github-actions Bot added a commit that referenced this pull request Jan 15, 2026
@Pratheek555

Copy link
Copy Markdown
Contributor Author

Commands like /help are still not visible in threads, so it might be worth looking into. Lennyface is working perfectly now, thanks for the fix.

Will surely look into it!

@Pratheek555

Copy link
Copy Markdown
Contributor Author

Hey @Spiral-Memory

Commands like /help are still not visible in threads

In the main rocketChat app when you type the /help command in threads, it shows up in the main channel itself and the same thing is happening with embedded chat too.

EmbeddedChat._.Simple.-.Simple.Storybook.Mozilla.Firefox.2026-01-16.18-39-14.mp4

Is it a issue with RocketChat itself or we keep it as intended?
I also checked most of the other commands, they seemed to work pretty fine after this current PR.

Lemme know if you want me to check anything else.

Thank you!

@Pratheek555

Copy link
Copy Markdown
Contributor Author

The /help issue has been fixed in the core Rochet.chat repo

here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a subtle fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FIX: Slash command responses are posted to the main channel instead of the thread in EmbeddedChat

2 participants