fix: disable strict mode for MCP tools to preserve optional parameters

[daniel-lxs]

Summary

MCP tools (like Linear's MCP server) have optional parameters that were broken by OpenAI's strict mode which requires ALL properties to be in the required array.

Changes

• Check if tool name starts with mcp-- prefix (indicating MCP tool)
• Set strict: false for MCP tools
• Preserve original schema without forcing all properties to required
• Keep strict mode for Roo's native tools which are designed for it

Files Changed

• src/api/providers/base-provider.ts - convertToolsForOpenAI()
• src/api/providers/openai-native.ts - buildRequestBody()

Testing

• All existing tests pass (38/38 openai-native, 10/10 mcp_server)
• TypeScript compilation passes

Fixes ROO-241

---

Important

Disable strict mode for MCP tools by checking for mcp-- prefix, preserving optional parameters while maintaining strict mode for native tools.

• Behavior:
  • Disable strict mode for MCP tools by checking for mcp-- prefix in convertToolsForOpenAI() in base-provider.ts and buildRequestBody() in openai-native.ts.
  • Preserve optional parameters for MCP tools, while keeping strict mode for native tools.
• Utilities:
  • Add isMcpTool() function in mcp-name.ts to identify MCP tools by prefix.
• Testing:
  • Add tests for isMcpTool() in mcp-name.spec.ts.
  • All existing tests pass.

^{This description was created by for 7b0985a. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Rooviewer   See task on Roo Cloud

Review completed. No issues found.

The refactoring correctly replaces the hardcoded "mcp--" prefix with a centralized isMcpTool helper function that uses the MCP_TOOL_PREFIX and MCP_TOOL_SEPARATOR constants. This addresses the feedback from the previous review and improves maintainability.

Previous reviews

• 60f5d67: Review #1

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}