DAO-1983 (C5/6): Migrate hooks — vault & shared readers (batch 3)#2096
Open
TravellerOnTheRun wants to merge 2 commits into
Open
DAO-1983 (C5/6): Migrate hooks — vault & shared readers (batch 3)#2096TravellerOnTheRun wants to merge 2 commits into
TravellerOnTheRun wants to merge 2 commits into
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
TravellerOnTheRun
force-pushed
the
dao-1983-c5
branch
from
71044a9 to
2e3c339
Compare
sleyter93
requested changes
Apr 15, 2026
|
|
||
| export const useNFTBoosterContext = () => useContext(BoosterContext) | ||
|
|
||
| export const axiosInstance = axios.create() |
Collaborator
There was a problem hiding this comment.
We shouldn't introduce an axios instance.
NFT booster data already uses native fetch via boost.utils; the axios instance was unused and violated the no-new-axios policy (DAO-1983).
sleyter93
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Vault and delegation flows need trustworthy, timely reads. This batch continues migrating hooks and shared contract readers off the legacy constant so they follow the same default as the rest of the app, with explicit opt-outs only where semantics require it.
What to check
Stack
C5 follows C4.