Skip to content

docs: record the v0.20.33 release traps - #830

Open
sanchitmonga22 wants to merge 1 commit into
mainfrom
docs/release-lessons-0.20.33
Open

docs: record the v0.20.33 release traps#830
sanchitmonga22 wants to merge 1 commit into
mainfrom
docs/release-lessons-0.20.33

Conversation

@sanchitmonga22

@sanchitmonga22 sanchitmonga22 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Four lessons from cutting v0.20.33, which took four candidates. Two of those were real
defects that would have shipped an SDK where TTS does not link.

The expensive one: a new NeuRT archive lands in FOUR places

Three of them only fail in a build configuration a dev Mac never produces:

  • Miss the force-load lists (build-core-xcframework.sh has two — a pre-flight guard and
    _NEURT_ROUTABLE_ARCHIVES — plus package-private-engine-overlay.sh) and every native job
    goes green while validate_consumer_flutter dies an hour later on
    Undefined symbol: _g_neurt_tts_ops. The engine registers, all CMake targets compile, and
    only a consumer's link fails.
  • Miss the #if RAC_NEURT_ROUTABLE guard on the vtable entry and the opposite happens:
    routable builds are fine, and every PR job without NEURUN_TOKEN fails, because the
    non-routable shell still references a symbol nothing defines.

A machine with the payload staged is routable, so it reproduces neither.

This file already records that prose alone did not stop the checksum-staleness bug recurring
twice — so the archive-list half now has a mechanism: neurt_assert_no_unlisted_archives
fails packaging by name and points at all three files. The vtable guard has none, hence the
instruction to audit all ten slots, and the note that moving core/third_party/neurt aside
reproduces a non-routable build in one step.

Three more

  • reuse_native_web_run_id is same-version-only. racommons.wasm embeds
    RAC_VERSION_STRING. Worse than the red job: native_web is skipped, so that candidate
    never uploads a web artifact and can never serve as publish_from_run_id.
  • Verify checksums by name as well as URL. The root manifest interpolates
    \(sdkVersion); the Flutter ones bind a checksum to a name: through a helper with no URL
    at the call site. A URL-only cross-check validates 9 of 15 sites and reports success.
  • rcli backends --json against the OSS kit proves nothing. NeuRT ships as a separate
    private pack, so the public bottle lists no neurt at all — the check passes cleanly and
    means nothing.
check_agents_claude_sync.sh   All 19 CLAUDE.md -> AGENTS.md symlink(s) present and tracked

🤖 Generated with Claude Code

https://claude.ai/code/session_01R6p1R4pwTg5pvVjiEjq9ZA

Summary by CodeRabbit

  • Documentation
    • Updated release pipeline lessons through version v0.20.33.
    • Added guidance on registering new NeuRT archives, matching versions when reusing web run IDs, and verifying checksums by both name and URL.

Four lessons from cutting v0.20.33, which took four candidates. Two were real
defects that would have shipped an SDK where TTS does not link.

The expensive one: a new NeuRT archive must be added in FOUR places, and three
only fail in a build configuration a dev Mac never produces. Miss the force-load
lists and every native job is green while validate_consumer_flutter dies an hour
later on `Undefined symbol: _g_neurt_tts_ops` -- the engine registers, all CMake
targets compile, only a CONSUMER's link fails. Miss the `#if RAC_NEURT_ROUTABLE`
guard on the vtable entry and the opposite happens: routable builds are fine and
every PR job without NEURUN_TOKEN fails, because the non-routable shell still
references a symbol nothing defines. A machine with the payload staged is
routable and reproduces neither.

This file already notes that prose alone did not stop the checksum-staleness bug
recurring twice, so the archive-list half now has a mechanism:
`neurt_assert_no_unlisted_archives` fails packaging by name. The vtable guard has
none -- hence the instruction to audit all ten slots, and the note that moving
core/third_party/neurt aside reproduces a non-routable build in one step.

Also recorded: reuse_native_web_run_id is same-version-only (the wasm embeds
RAC_VERSION_STRING, and a skipped native_web leaves the candidate unusable for
publish_from_run_id); checksum verification must match by NAME as well as URL,
because a URL-only cross-check validates 9 of 15 sites and reports success; and
`rcli backends --json` against the OSS kit lists no neurt at all, so a
routability check there passes cleanly and proves nothing.

    check_agents_claude_sync.sh   All 19 CLAUDE.md -> AGENTS.md symlinks present

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R6p1R4pwTg5pvVjiEjq9ZA
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 9a03f97a-b6d0-405b-883a-4b1f63b92d5f

📥 Commits

Reviewing files that changed from the base of the PR and between a931bd2 and 7fc4108.

📒 Files selected for processing (1)
  • AGENTS.md

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Release pipeline lessons

Layer / File(s) Summary
Pipeline version and NeuRT registration
AGENTS.md
Extends the documented release lesson range through v0.20.33 and records the four NeuRT archive registration points.
Release validation checks
AGENTS.md
Documents same-version web run reuse, checksum checks by name and URL, and private NeuRT overlay verification.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 7fc41

This change only records release-process lessons in repository documentation and does not alter product or runtime behavior; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: siddhesh2377

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description gives a detailed and relevant account of the four release lessons, but it does not follow the repository template. It omits the required Description, Type of Change, Testing, Labels, C… Reformat the description using the repository template. Add the required sections, select Documentation update, record applicable testing results, identify labels, complete the checklist, and state whether screenshots are not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the documentation change and the v0.20.33 release traps recorded in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description gives a detailed and relevant account of the four release lessons, but it does not follow the repository template. It omits the required Description, Type of Change, Testing, Labels, Checklist, and Screenshots sections.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/release-lessons-0.20.33

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant