Open
Conversation
Author
|
@sjanuary Hi. I reopened a new PR with a cleaner commit log and the changes you wanted. Thanks for the help. Let me know if anything else needs changed. |
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
- Coverage 60.8% 60.45% -0.36%
==========================================
Files 49 50 +1
Lines 3215 3252 +37
==========================================
+ Hits 1955 1966 +11
- Misses 1260 1286 +26
Continue to review full report at Codecov.
|
Contributor
|
This is looking good to me, we just need to find the time to try it out ourselves, but we do aim to get this merged (might be after Christmas) |
|
Hello, Any news from this merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#494
I created a new PR with a cleaner commit history.