Skip to content

Conversation

@simlay
Copy link
Member

@simlay simlay commented Dec 11, 2025

I tried to bump this to 0.13.1 rather than 0.14.0 but cargo semver-checks convinced me otherwise:

cargo semver-checks
    Building coreaudio-rs v0.13.1 (current)
       Built [   1.985s] (current)
     Parsing coreaudio-rs v0.13.1 (current)
      Parsed [   0.005s] (current)
    Building coreaudio-rs v0.13.0 (baseline)
       Built [   1.697s] (baseline)
     Parsing coreaudio-rs v0.13.0 (baseline)
      Parsed [   0.005s] (baseline)
    Checking coreaudio-rs v0.13.0 -> v0.13.1 (minor change)
     Checked [   0.013s] 159 checks: 153 pass, 6 fail, 0 warn, 41 skip

--- failure derive_trait_impl_removed: built-in derived trait no longer implemented ---

Description:
A public type has stopped deriving one or more traits. This can break downstream code that depends on those types implementing those traits.
        ref: https://doc.rust-lang.org/reference/attributes/derive.html#derive
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/derive_trait_impl_removed.ron

Failed in:
  type AppleLosslessFlags no longer derives PartialEq, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:414
  type AppleLosslessFlags no longer derives Eq, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:414
  type AppleLosslessFlags no longer derives PartialOrd, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:414
  type AppleLosslessFlags no longer derives Ord, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:414
  type AppleLosslessFlags no longer derives Hash, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:414
  type AudioTimeStampFlags no longer derives PartialEq, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:496
  type AudioTimeStampFlags no longer derives Eq, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:496
  type AudioTimeStampFlags no longer derives PartialOrd, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:496
  type AudioTimeStampFlags no longer derives Ord, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:496
  type AudioTimeStampFlags no longer derives Hash, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:496
  type LinearPcmFlags no longer derives PartialEq, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:352
  type LinearPcmFlags no longer derives Eq, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:352
  type LinearPcmFlags no longer derives PartialOrd, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:352
  type LinearPcmFlags no longer derives Ord, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:352
  type LinearPcmFlags no longer derives Hash, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:352
  type StandardFlags no longer derives PartialEq, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:297
  type StandardFlags no longer derives Eq, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:297
  type StandardFlags no longer derives PartialOrd, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:297
  type StandardFlags no longer derives Ord, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:297
  type StandardFlags no longer derives Hash, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/audio_format.rs:297
  type ActionFlags no longer derives Copy, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304
  type ActionFlags no longer derives PartialEq, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304
  type ActionFlags no longer derives Eq, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304
  type ActionFlags no longer derives Clone, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304
  type ActionFlags no longer derives PartialOrd, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304
  type ActionFlags no longer derives Ord, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304
  type ActionFlags no longer derives Hash, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304
  type ActionFlags no longer derives Copy, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304
  type ActionFlags no longer derives PartialEq, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304
  type ActionFlags no longer derives Eq, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304
  type ActionFlags no longer derives Clone, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304
  type ActionFlags no longer derives PartialOrd, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304
  type ActionFlags no longer derives Ord, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304
  type ActionFlags no longer derives Hash, in /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/render_callback.rs:304

--- failure enum_no_repr_variant_discriminant_changed: enum variant had its discriminant change value ---

Description:
The enum's variant had its discriminant value change. This breaks downstream code that used its value via a numeric cast like `as isize`.
        ref: https://doc.rust-lang.org/reference/items/enumerations.html#assigning-discriminant-values
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_no_repr_variant_discriminant_changed.ron

Failed in:
  variant Error::Unspecified 0 -> 2003329396 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:150
  variant Error::UnsupportedProperty 1 -> 1886547824 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:151
  variant Error::BadPropertySize 2 -> 561211770 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:152
  variant Error::BadSpecifierSize 3 -> 561213539 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:153
  variant Error::UnknownFormat 1718449216 -> 560360820 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:155
  variant Error::Unknown 1718449217 -> 560360821 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:156
  variant Error::Unspecified 0 -> 2003329396 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:150
  variant Error::UnsupportedProperty 1 -> 1886547824 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:151
  variant Error::BadPropertySize 2 -> 561211770 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:152
  variant Error::BadSpecifierSize 3 -> 561213539 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:153
  variant Error::UnknownFormat 1718449216 -> 560360820 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:155
  variant Error::Unknown 1718449217 -> 560360821 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:156
  variant Error::Unknown 560100711 -> 1650549858 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:91
  variant Error::Unknown 560100711 -> 1650549858 in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:91

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_variant_added.ron

Failed in:
  variant Error:BadData in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:90
  variant Error:BadData in /Users/simlay/projects/rust-audio/coreaudio-rs/src/error.rs:90

--- failure enum_variant_missing: pub enum variant removed or renamed ---

Description:
A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_variant_missing.ron

Failed in:
  variant IOType::RemoteIO, previously in file /Users/simlay/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/coreaudio-rs-0.13.0/src/audio_unit/types.rs:444
  variant IOType::RemoteIO, previously in file /Users/simlay/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/coreaudio-rs-0.13.0/src/audio_unit/types.rs:444

--- failure function_unsafe_added: pub fn became unsafe ---

Description:
A publicly-visible function became `unsafe`, so calling it now requires an `unsafe` block.
        ref: https://doc.rust-lang.org/book/ch19-01-unsafe-rust.html#calling-an-unsafe-function-or-method
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/function_unsafe_added.ron

Failed in:
  function coreaudio::audio_unit::get_property in file /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/mod.rs:425
  function coreaudio::audio_unit::set_property in file /Users/simlay/projects/rust-audio/coreaudio-rs/src/audio_unit/mod.rs:387

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/inherent_method_missing.ron

Failed in:
  AppleLosslessFlags::from_bits_unchecked, previously in file /Users/simlay/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/coreaudio-rs-0.13.0/src/audio_unit/audio_format.rs:391
  AudioTimeStampFlags::from_bits_unchecked, previously in file /Users/simlay/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/coreaudio-rs-0.13.0/src/audio_unit/audio_format.rs:470
  LinearPcmFlags::from_bits_unchecked, previously in file /Users/simlay/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/coreaudio-rs-0.13.0/src/audio_unit/audio_format.rs:330
  StandardFlags::from_bits_unchecked, previously in file /Users/simlay/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/coreaudio-rs-0.13.0/src/audio_unit/audio_format.rs:276
  ActionFlags::from_bits_unchecked, previously in file /Users/simlay/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/coreaudio-rs-0.13.0/src/audio_unit/render_callback.rs:304
  ActionFlags::from_bits_unchecked, previously in file /Users/simlay/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/coreaudio-rs-0.13.0/src/audio_unit/render_callback.rs:304

     Summary semver requires new major version: 6 major and 0 minor checks failed
    Finished [   4.599s] coreaudio-rs

The changes include are 93287e2...90d49fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant