Fix batch_processing GLOA bounds#132
Open
bernalde wants to merge 1 commit into
Open
Conversation
bernalde
commented
May 12, 2026
bernalde
left a comment
Member
Author
There was a problem hiding this comment.
No blocking issues found.
Review summary:
- Blocking issues: none.
- Nonblocking issues: none requiring inline comments.
- Questions: none.
- Tests run and outcomes:
/home/bernalde/.pixi/bin/pixi run pytest tests/test_batch_processing.py -v --tb=short: 4 passed, 1 skipped./home/bernalde/.pixi/bin/pixi run env GDPLIB_RUN_GAMS_BARON_TESTS=1 pytest tests/test_batch_processing.py::test_batch_processing_gloa_runs_with_gams_baron -v --tb=short: 1 passed./home/bernalde/.pixi/bin/pixi run test: 288 passed, 2 skipped./home/bernalde/.pixi/bin/pixi run lint: passed with exit code 0; the broad flake8 command printed existing--exit-zerostyle statistics.git diff --check origin/main...HEAD: passed.
- Merge recommendation: the PR is merge-ready from this review. Since I am the PR author, GitHub does not allow me to provide an eligible approval; an eligible maintainer should approve before merge.
Member
Author
|
Comment follow-up status:
|
48d93d3 to
bb39f7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
batch_processing.cycleTime_log.build_model()API and solver-free construction path.Tests run
/home/bernalde/.pixi/bin/pixi run pytest tests/test_batch_processing.py -v --tb=short/home/bernalde/.pixi/bin/pixi run env GDPLIB_RUN_GAMS_BARON_TESTS=1 pytest tests/test_batch_processing.py::test_batch_processing_gloa_runs_with_gams_baron -v --tb=short/home/bernalde/.pixi/bin/pixi run pytest tests/test_module_imports.py -v --tb=short/home/bernalde/.pixi/bin/pixi run test/home/bernalde/.pixi/bin/pixi run lint--exit-zerostyle statistics./home/bernalde/.pixi/bin/pixi run gdplib-benchmark run --instances batch_processing --strategies gdpopt.gloa --solver-profile gams-local --timelimit 120 --run-id issue61_postbounds_gloa_local_20260511maxTimeLimitsolver result with finite lower/upper bounds instead of the pre-patch FBBT assertion. The CLI then exited while generating summaries becausegenerate_benchmark_summary_allis not importable in this checkout.Notes
cycleTime_log[...]variable and failed in Pyomo FBBT withAssertionError.Closes #61