Bound batch processing cycle times#134
Open
bernalde wants to merge 1 commit into
Open
Conversation
bernalde
commented
May 12, 2026
bernalde
left a comment
Member
Author
There was a problem hiding this comment.
-
Blocking issues: none.
-
Nonblocking issues: none.
-
Questions: none.
-
Tests run and outcomes:
env PYTHONPATH=. /home/bernalde/.pixi/bin/pixi run pytest tests/test_batch_processing.py tests/test_benchmark.py tests/test_release_workflow.py -v --tb=shortResult: 26 passed.
/home/bernalde/.pixi/bin/pixi run testResult: 288 passed, 1 skipped.
/home/bernalde/.pixi/bin/pixi run lintResult: passed. The configured exit-zero flake8 report still prints existing repository style debt.
git diff --check origin/main...HEADResult: passed.
CI is also green for coverage, lint/style-and-typos, pip installation, and Python 3.10/3.11/3.12.
- Merge verdict: this PR is merge-ready from my review. I cannot submit an APPROVE review from this account because it is the PR author, so an eligible reviewer still needs to approve.
This was referenced May 12, 2026
6996d42 to
3409cb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
batch_processing.cycleTime_logfrom the production horizon and processing-time constraints.option optcr=1e-6consistently for direct transformed solves and GDPopt GAMS role solves.Note: this branch addresses the
batch_processingbenchmark issue, which is #61. Issue #62 is the separatebiofuelissue, so this PR intentionally does not close #62.Solver Evidence
Direct transformed verification:
Result: 6 rows, 0 failures. BARON/DICOPT objectives were unchanged to numerical tolerance:
679365.334866, optimal.679365.323287, optimal.679365.334869, optimal.679365.334507, optimal.GDPopt GLOA verification:
Result: 1 row, 0 failures. GLOA now reaches
maxTimeLimitinstead of failing in Pyomo FBBT. Removing only the newcycleTime_logbounds reproduced the old warning andAssertionErrorpath.Tests Run
Result: 26 passed.
/home/bernalde/.pixi/bin/pixi run testResult: 288 passed, 1 skipped.
Result: passed. The configured exit-zero flake8 report still prints existing repository style debt.
Result: passed.
Notes
The direct targeted command without
PYTHONPATH=.:failed during collection because
tests/test_benchmark.pyimports the repo-rootbenchmark.py; the full documentedpixi run testpath passes.Closes #61.