Fix modprodnet distributed pair activation#141
Open
bernalde wants to merge 1 commit into
Open
Conversation
a777b7a to
c3b59d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modprodnetsite-pair inactive disjunct so it represents "not both sites active" instead of forcing both sites inactive.modprodnetcases, Big-M/Hull reformulation smoke tests, invalid case handling, and the corrected pair-inactive semantics.Tests run
/home/bernalde/.pixi/bin/pixi run pytest tests/test_modprodnet.py -v --tb=short24 passed in 4.74s/home/bernalde/.pixi/bin/pixi run pytest tests/test_module_imports.py -v --tb=short68 passed in 6.43s/home/bernalde/.pixi/bin/pixi run python - <<'PY' ... PYmodprodnetusing GAMS-local role solvers (nlp=ipopth,mip=gurobi,minlp=dicopt,local_minlp=dicopt), 60s time limit.ok, terminationoptimal, objective/lower/upper bound3592.9243356537468./home/bernalde/.pixi/bin/pixi run test308 passed, 1 skipped in 26.44s/home/bernalde/.pixi/bin/pixi run lintflake8 --exit-zerostyle inventory was printed.git diff --checkNotes
gdplib-benchmark run --instances modprodnet --strategies gdpopt.gloa --timelimit 60 --run-id issue72_gloa_probe --solver-profile gams-localprobe produced an optimal per-case result, but the benchmark CLI exited during summary generation becausegenerate_benchmark_summary_allis not available in this checkout. The direct GDPopt GLOA solve above was used as the clean solver-backed verification.Closes #72