Repository navigation
Phase 0: CLOB foundations, spec status, and WASM size gate - #1101
Merged
IbrahimIjai merged 1 commit intoOct 21, 2026
Merged
Conversation
The wasm-size workflow was dropped in the CLOB reset, so contract growth was no longer checked. Restore the budget as a job in ci.yml, named "Build & check WASM sizes" so it can be marked required, and add it to the ci-passed gate. On pull requests the PR head and the base branch are both built and compared: growth over 5% warns and over 10% blocks. On push to main there is no base, so sizes are only reported. The comparison lives in scripts/wasm-size-check.py and writes the table to the step summary. Refs SO4-Markets#530
|
@devwura Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Covers the four Phase 0 issues assigned to @devwura. Most of this work already landed on
mainthrough earlier CLOB PRs, so this PR adds the one piece that was still missing and records the status of each issue.Per issue
gmx-synthetic-order-book-dex#877 (archive the GMX implementation):docs/legacy-archive.mdonmainrecords archive point5436392, which is the parent of the reset merge280f268. Not done: thegmx-synthetic-order-book-dexbranch does not exist onSO4-Markets/contracts. It exists only on a contributor fork. A maintainer needs to push it upstream before the clean-clone check can run.docs/protocol.mdcovers scope, v1 non-goals, rounding, equal-price orders, and zero remainder. No change in this PR.docs/protocol.mdsection 9 lists I1–I12, each with a planned test category. Section 10 covers the bounded stop and worked examples. No change in this PR.main#530 (CI hardening):ci.ymlalready runs onpushtomain, usesclippy --all-targets, has a test job, and has theci-passedgate. This PR adds the WASM size budget job (Build & check WASM sizes), which was missing. Still open: marking the checks as required in branch protection (a repo setting), and the demonstrated-failure runs.Known blocker
origin/mainhas no rootCargo.tomlorMakefilesince the reset in31924e5. Every CI job that builds or tests will fail until #529 restores the workspace. This PR does not fix that.This was not built or tested locally. CI is the first run.
closes #877,closes #878,closes #879,closes #530