Repository navigation
Implement enumerable market registry and factory deployment - #1104
Merged
SteffQing merged 1 commit intoOct 21, 2026
Merged
Conversation
- Issue SO4-Markets#15: Enumerable market registry with O(1) lookup and bounded pagination - Issue SO4-Markets#14 (part 2): Market deployment and MarketCreated event emission - Issue SO4-Markets#14 (part 1): Market factory config validation and duplicate rejection Delivers: - Bounded enumeration (max 100 markets/page, no unbounded iteration) - Deterministic market ID derivation from (base, quote) pair - Idempotent market creation (no duplicates) - Full configuration validation (11 validation checks) - Immutable fields (base, quote, lot_size, tick_size, fees) - Soft-delete TTL for market closure - MarketCreated event with complete configuration - 25+ comprehensive tests covering positive and negative paths - Complete documentation with API specs and examples
|
@ayobami-dale Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements market discovery and deployment infrastructure for Phase 1 (market creation, custody, balances). Delivers three core backlog items covering registry enumeration, factory deployment with deterministic IDs, and configuration validation with duplicate rejection.
closes #897
closes #898
closes #899
1. Market Registry (Issue #15 - Bounded Enumeration)
Purpose: Clients need canonical way to discover markets without scanning contract history.
Features:
part 2) — Market deployment and MarketCreated event
(part 1) — Config validation and duplicate rejection