Skip to content

Enable tag deployment - #623

Open
EricvanSchaik wants to merge 1 commit into
mainfrom
feature/enable-tag-deployment
Open

Enable tag deployment#623
EricvanSchaik wants to merge 1 commit into
mainfrom
feature/enable-tag-deployment

Conversation

@EricvanSchaik

@EricvanSchaik EricvanSchaik commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

git describe --exact does not work for some reason, directly taking the tag seems to work better. My hypothesis would be that normally the release branches are used instead of releasing old tags. If releasing old tags is very common, it could be an error on my machine, in that case don't approve

git describe --exact does not work for some reason, directly taking the tag seems to work better.

@baszoetekouw baszoetekouw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik kan het nieuw zo goed beoordelen. Als het werkt lijkt het me prima :)
Ter referentie, in opencoenxt-deploy doen we dit:

# What is our git situation?
get_git_tag() {
    local result
    if ! result=$(git describe --tags 2> /dev/null); then
        result="no tags found"
    fi
    echo "$result"
}
get_git_branch() {
    local result
    if ! result=$(git branch --show-current 2> /dev/null); then
        result="no branch found"
    fi
    echo "$result"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants