Fix duplicate attributes - #149
Closed
mrvanes wants to merge 1 commit into
Closed
Conversation
baszoetekouw
left a comment
baszoetekouw
left a comment
Member
There was a problem hiding this comment.
Ik vind dit tricky om te beoordelen, omdat dit alle ldap output raakt. Op z'n minst zal het iets doen met de ordening van alle multi-values attributen. Ik vraag me af of dat wenselijk is want dan wordt het onmogelijk om te zien wat er inhoudelijk verandert.
baszoetekouw
requested changes
Jul 20, 2026
mrvanes
force-pushed
the
fix/mv_attributes
branch
from
July 20, 2026 07:30
073d7f4 to
a3392b1
Compare
Contributor
|
Deze is inmiddels al ge-cherry-picked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dit is geverifiëerd in: #150
We zullen het nu mergen omdat het toch stuk is en moet worden gehotfixed.