Add Persona picker in Room Input#1171
Draft
j0lol wants to merge 1 commit into
Draft
Conversation
Author
|
Names and such are in a bit of a rough state but it is MVP "working". Going to work on it a bit more before I'm comfortable un-drafting this. Screencast_20260721_011126.webm(In the video the first switch is buggy, but the rest work fine.) Making UI for plural systems is new territory, so I'd like feedback from other systems if possible. I'm asking around for feedback. |
Contributor
|
fwiw, while I'm here I'll leave some thoughts that j0 already knows of but I didn't share publicly yet: I believe that good keyboard navigation would be very nice to have, in addition to using prefixes or pk; commands like what Sable already does I was thinking something like alt+P or alt+↑ might work? From that point on the search is focused, or entries could be manually tabbed/↓↑ through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a PMP/Persona picker in the room input, so a user can switch between personas graphically (without shorthands or
/usepmp.)Type of change
Checklist:
AI disclosure: