fix: constrain bug report modal to viewport height#652
Open
mvanhorn wants to merge 2 commits intoSableClient:devfrom
Open
fix: constrain bug report modal to viewport height#652mvanhorn wants to merge 2 commits intoSableClient:devfrom
mvanhorn wants to merge 2 commits intoSableClient:devfrom
Conversation
Add maxHeight: 90vh to the Modal and its inner Box container so the bug report screen doesn't overflow beyond the viewport, which was causing the close button and header text to be cropped off. Fixes SableClient#629
Contributor
|
hey it seems like you're missing a changeset. Can you please add a changeset, as described here https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md#documenting-a-change Thank you |
Contributor
|
not that it is particularly relevant in such a small change but could you please follow the PR template and AI disclosure since it is applicable |
Author
|
Updated the PR body with the full template and AI disclosure section, and added a changeset. Thanks for flagging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Constrains the bug report modal to 90vh max height so it doesn't overflow the viewport, which was cropping the close button and header text.
Fixes #629
Type of change
Checklist:
AI disclosure:
The
maxHeightandoverflowstyle additions toBugReportModal.tsxwere written alongside an AI tool. The changes addmaxHeight: '90vh'to the MUI Modal component and its inner Box container, withoverflow: 'hidden'on the Box to prevent the modal from growing beyond the viewport. The inner content area usesoverflowY: 'auto'so the form fields remain scrollable within the constrained modal.