fix(notifications): pass room and userId context to reaction notification filter

[Just-Insane]

Description

isNotificationEvent in room.ts already has logic to only surface reaction notifications for reactions to the current user's messages — but both call sites were invoking it without the required room and userId arguments, causing it to hit the safe-default branch that silently filters out all reactions.

This change passes room and mx.getUserId() at both notification paths so the existing filter works as intended:

• BackgroundNotifications.tsx — background/multi-account notification path
• ClientNonUIFeatures.tsx — foreground in-app notification path

Fixes #

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

AI disclosure:

• Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).

The two changed call sites were identified and modified with AI assistance. The fix passes room and mx.getUserId() ?? undefined to isNotificationEvent so that the existing reaction-ownership check in room.ts receives the context it needs to function correctly.

[Copilot]

Pull request overview

Fixes reaction notifications being silently filtered out by ensuring isNotificationEvent receives the required room and userId context at both notification entry points.

Changes:

• Pass room and mx.getUserId() ?? undefined into isNotificationEvent in the foreground (in-app) notification path.
• Pass room and mx.getUserId() ?? undefined into isNotificationEvent in the background/multi-account notification path.
• Add a changeset documenting the patch-level fix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/app/pages/client/ClientNonUIFeatures.tsx	Fixes foreground notification filtering by providing room/userId context to reaction filtering logic.
src/app/pages/client/BackgroundNotifications.tsx	Fixes background notification filtering by providing room/userId context to reaction filtering logic.
.changeset/reaction-notification-context.md	Documents the user-facing patch change for release notes/versioning.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This condition line exceeds the repo’s Prettier printWidth (100) and will fail pnpm run fmt:check. Please run Prettier (or wrap the if condition across multiple lines) so formatting checks pass.

Suggested change

	if (!room || isHistoricalEvent || room.isSpaceRoom() || !isNotificationEvent(mEvent, room, mx.getUserId() ?? undefined)) {
	if (
	!room ||
	isHistoricalEvent ||
	room.isSpaceRoom() ||
	!isNotificationEvent(mEvent, room, mx.getUserId() ?? undefined)
	) {

[Copilot]

The release-note line is over the repo’s Prettier printWidth (100) and will be reformatted/fail pnpm run fmt:check. Please wrap the summary onto multiple lines (keeping it as a single paragraph).

Suggested change

	Fix reaction notifications not being delivered by passing room and user context to the notification event filter
	Fix reaction notifications not being delivered by passing room and user
	context to the notification event filter