fix: cross-instance settings link recognition without hardcoded app.sable.moe#695
Merged
fix: cross-instance settings link recognition without hardcoded app.sable.moe#695
Conversation
Member
Author
|
adding one last thing before being ready |
Member
Author
|
It ended up being many things. I updated the PR description. |
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-695-sable.raspy-dream-bb1d.workers.dev | 87da39e | pr-695 |
Sun, 19 Apr 2026 11:47:25 GMT |
7w1
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #646
Changed settings link behavior to use a query parameter marker instead, this avoids hardcoding
app.sable.moe, keeps links valid on non-Sable clients, and lets self-hosted Sable instances recognize links copied from other Sable instances without misclassifying arbitrary third-party/settings/...URLs.Example:
https://client.example/settings/account?focus=display-name&moe.sable.client.action=settingsEdit:
I've ended up expanding the scope of the PR. Thanks to some suggestions from @dozro and also general QoL improvements.
[Settings > Emojis & Stickers > Select Pack](http://localhost:8080/settings/emojis?focus=select-pack&moe.sable.client.action=settings)Migration note:
settingsLinkBaseUrlis no longer used and can be removed fromconfig.json.Type of change
Checklist:
AI disclosure: