Skip to content

fix: test_row_validation_result_filter_operation error #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linglp merged 1 commit into from
Jul 28, 2026
+9 −8
Merged

fix: test_row_validation_result_filter_operation error #1437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions tests/integration/synapseclient/models/async/test_grid_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,10 +707,15 @@ async def test_row_is_valid_filter_returns_only_invalid_rows(
# LIKE '%' matches any non-empty message, so only the invalid
# rows (which have a message) match.
pytest.param(ValidationOperator.LIKE, "%", {3, 4}, id="like"),
# NOT_LIKE '%' never matches: invalid rows have a message that
# matches '%' (and so are excluded), while valid rows have no
# message at all to compare against.
pytest.param(ValidationOperator.NOT_LIKE, "%", set(), id="not_like"),
# LIKE on this specific message should only match row 4.
pytest.param(
ValidationOperator.LIKE,
"%1500.0 is not less or equal to 1000%",
{4},
id="like_specific_message",
),
# NOT_LIKE '%' matches rows with no message at all (valid rows):
pytest.param(ValidationOperator.NOT_LIKE, "%", {1, 2, 5}, id="not_like"),
Comment thread
linglp marked this conversation as resolved.
],
)
async def test_row_validation_result_filter_operators(
Expand Down Expand Up @@ -739,10 +744,6 @@ async def test_row_validation_result_filter_operators(

# THEN: Only the rows matching that operator/value are returned
assert {row.data["id"] for row in result.rows} == expected_ids
Comment thread
linglp marked this conversation as resolved.
if expected_ids:
assert all(
row.validation_results.all_validation_messages for row in result.rows
)

async def test_row_id_filter_returns_only_specified_rows(
self, connected_grid: Grid
Expand Down
Loading