Skip to content

feat(storybook): upgrade to v10#7368

Merged
nineteen88 merged 1 commit into
masterfrom
FE-7277
Jun 10, 2026
Merged

feat(storybook): upgrade to v10#7368
nineteen88 merged 1 commit into
masterfrom
FE-7277

Conversation

@nineteen88

@nineteen88 nineteen88 commented Jun 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed behaviour

  • update storybook and all dependencies to use v10
  • change the way we hide stories to the documented method as per Storybook docs

Current behaviour

  • update is currently on v8

Checklist

  • Commits follow our style guide
  • Storybook added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@nineteen88 nineteen88 requested review from a team as code owners June 6, 2025 15:31
edleeks87
edleeks87 reviewed Jun 9, 2025
View reviewed changes
Comment thread .storybook/version-picker/index.tsx
TooltipLinkList,
TooltipLinkListLink,
} from "@storybook/components";
} from "storybook/internal/components";

@edleeks87 edleeks87 Jun 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: the migration docs indicate anything moved to internal might be deprecated in v10, is this the right package to use here and if we have to do we have a ticket/plan for migrating off it asap?

@nineteen88 nineteen88 Jun 9, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is within our addon (version-picker) and the migration docs also mention:

"Addon authors may continue to use the internal packages, there is currently not yet any replacement."

I might create a ticket to keep an eye on it essentially, but not sure there's much that can be done right now other that rewrite all these components and make them internal for our Storybook only?

@Parsium Parsium Jun 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: what do you think about adding a comment briefing explaining this and/or linking to the ticket once its raised?

Might be worth being clear Storybook only recommend addon authors use this API and it shouldn't be used elsewhere.

Comment thread .storybook/manager.ts Outdated
import { ADDON_ID, TOOL_ID } from "./version-picker/constants";
import { VersionPicker } from "./version-picker";
import { API_PreparedIndexEntry, API_StatusObject } from "@storybook/types";
import { API_PreparedIndexEntry } from "storybook/internal/types";

@edleeks87 edleeks87 Jun 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is this still needed? If it is, is it the appropriate type to use given that it's now internal?

@nineteen88 nineteen88 self-assigned this Jun 9, 2025
@nineteen88 nineteen88 force-pushed the FE-7277 branch 2 times, most recently from db4acba to 79d67fa Compare June 9, 2025 14:38
edleeks87
edleeks87 previously approved these changes Jun 10, 2025
View reviewed changes
@Parsium Parsium self-requested a review June 11, 2025 07:53
Parsium
Parsium previously approved these changes Jun 11, 2025
View reviewed changes
@nineteen88 nineteen88 dismissed stale reviews from Parsium and edleeks87 via 9976de6 July 10, 2025 10:53
@nineteen88 nineteen88 force-pushed the FE-7277 branch 3 times, most recently from 6a5f8c6 to e2e8404 Compare July 10, 2025 12:53
@nineteen88

nineteen88 commented Aug 8, 2025

Copy link
Copy Markdown
Contributor Author

Blocked until this is resolved storybookjs/storybook#32007

@nineteen88 nineteen88 force-pushed the FE-7277 branch 2 times, most recently from 2aa33a1 to 5943b5e Compare March 19, 2026 02:08
@nineteen88 nineteen88 requested a review from a team as a code owner March 19, 2026 02:08
@nineteen88 nineteen88 force-pushed the FE-7277 branch 2 times, most recently from 19df6eb to dd8e86b Compare March 19, 2026 02:19
@nineteen88 nineteen88 requested a review from a team as a code owner March 19, 2026 02:19
@nineteen88 nineteen88 changed the title feat(storybook): upgrade to v9 feat(storybook): upgrade to v10 Mar 19, 2026
tomdavies73
tomdavies73 reviewed May 5, 2026
View reviewed changes

@tomdavies73 tomdavies73 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing further to add from me @nineteen88, there does seem to still be some leftover legacy usage of hideInSidebar. Apart from that it looks good though!

Image

DipperTheDan
DipperTheDan reviewed May 6, 2026
View reviewed changes

@DipperTheDan DipperTheDan left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a few things. Mainly the two screenshots showing some files that shouldn't be there.
Image

Image
I've also noticed that the interaction stories aren't working too. Screenshot of how they look. Image

@nineteen88

nineteen88 commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

I noticed a few things. Mainly the two screenshots showing some files that shouldn't be there. Image

I believe these are resolved with the next push of changes.

Image I've also noticed that the interaction stories aren't working too. Screenshot of how they look. Image

Judging by this screenshot it looks like the Interaction tests are disabled on the toolbar at the top, and would explain why they're not running? They seem to work fine for me

@nineteen88 nineteen88 force-pushed the FE-7277 branch 2 times, most recently from b0d6543 to a11ba2f Compare May 8, 2026 16:51
tomdavies73
tomdavies73 previously approved these changes May 11, 2026
View reviewed changes
DipperTheDan
DipperTheDan previously approved these changes May 11, 2026
View reviewed changes
@paulrobinson88 paulrobinson88 marked this pull request as draft May 12, 2026 11:14
@paulrobinson88 paulrobinson88 marked this pull request as ready for review May 12, 2026 11:14
@nineteen88 nineteen88 dismissed stale reviews from DipperTheDan and tomdavies73 via aedd560 May 12, 2026 14:13
@nineteen88 nineteen88 force-pushed the FE-7277 branch 2 times, most recently from aedd560 to 9a03e3d Compare May 12, 2026 14:35
@nineteen88 nineteen88 force-pushed the FE-7277 branch 3 times, most recently from 3280628 to ed1a36d Compare June 9, 2026 15:41
@nineteen88
feat(storybook): upgrade to v10.4.2
9e9a057 
- change the way we hide stories to the documented method as per Storybook docs
@nineteen88 nineteen88 merged commit e927352 into master Jun 10, 2026
37 of 38 checks passed
@nineteen88 nineteen88 deleted the FE-7277 branch June 10, 2026 13:49
@carbonci

carbonci commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 159.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@edleeks87 edleeks87 edleeks87 approved these changes

@tomdavies73 tomdavies73 tomdavies73 approved these changes

@paulrobinson88 paulrobinson88 paulrobinson88 approved these changes

@Parsium Parsium Parsium left review comments

@DipperTheDan DipperTheDan DipperTheDan left review comments

Assignees

@nineteen88 nineteen88

Labels

Passed QA Passed Review released Squad Front End

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nineteen88 @carbonci @Parsium @edleeks87 @DipperTheDan @tomdavies73 @paulrobinson88