Flat table improvements#7892
Draft
edleeks87 wants to merge 3 commits into
Draft
Conversation
edleeks87
force-pushed
the
flat-table-improvements
branch
from
22ee5a6 to
34c90e6
Compare
edleeks87
added
DO NOT MERGE
Work in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Refactors FlatTable and FlatTableRow to consolidate state into a reducer, remove the asynchronous setting of tabIndexes in the rows whilst lifting the state into the parent wrapper.
Current behaviour
State is computed and set in the rows/children.
State is set separately in a layout effect meaning each triggers an update.
The tabIndex is computed and checked asynchronously
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
Confirm no regressions
I can build 500 rows tables for whoever QAs to check but as the original issue was not reproduced as requested when it was raised I cannot guarantee that we will identify any niche implementations that might hinder performance.
master example of table