fix(filterable-select): refactor updateValues to avoid rerender issue

[robinzigmond]

refactor updateValues to not use a functional state update, which is unnecessary here. The calling of other state update functions inside this function is likely to be the cause of recursive rerender issues that we are seeing.

fix #7919

Proposed behaviour

Current behaviour

Checklist

• Commits follow our style guide
• Related issues linked in commit messages if required
• Screenshots are included in the PR if useful
• All themes are supported if required
• Unit tests added or updated if required
• Playwright automation tests added or updated if required
• Storybook added or updated if required
• Translations added or updated (including creating or amending translation keys table in storybook) if required
• Typescript d.ts file added or updated if required
• Related docs have been updated if required

QA

• Tested in provided StackBlitz sandbox/Storybook
• Add new Playwright test coverage if required
• Carbon implementation matches Design System/designs
• UI Tests GitHub check reviewed if required

Additional context

Testing instructions