chore: refactor packages#7923
Closed
tomdavies73 wants to merge 7 commits into
Closed
Conversation
tomdavies73
added
DO NOT MERGE
Work in progress
tomdavies73
force-pushed
the
refactor_packages
branch
from
5f7d61e to
5187765
Compare
file-loader, url-loader and css-loader are webpack-specific and have no imports anywhere in the codebase. The project uses Rollup and Vite.
- @types/jest: jest v29+ ships its own type declarations - @types/uuid: uuid v14 ships its own type declarations - @types/sinon: sinon is not installed in this project (only @sinonjs/* scoped packages are present)
@storybook/addon-essentials already depends on and registers addon-actions, addon-controls, addon-toolbars and addon-viewport. Explicitly listing them is redundant at the same version pin. Removed from both devDependencies and the addons[] array in .storybook/main.ts.
isFragment() was the only usage of react-is. Replaced with an inline isValidElement(x) && x.type === Fragment check in both call sites, sourcing Fragment directly from React. Removes react-is and @types/react-is.
chalk was a runtime dependency used only in a dev-time script (scripts/check_node_version.mjs) for a single red error message. Replaced with a bare ANSI escape sequence (\x1b[31m...\x1b[0m). Removes chalk from dependencies entirely.
node-fetch was used for a single fetch() call in scripts/generate_metadata/generate_metadata.mjs. The project requires Node >=24 which ships global fetch natively (available since Node 18). Removes node-fetch from devDependencies entirely.
tomdavies73
force-pushed
the
refactor_packages
branch
from
5187765 to
dd4d7ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Current behaviour
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions