feat(portrait): align component with Fusion DS#7932
Merged
Conversation
mihai-albu-sage
force-pushed
the
FE-7511
branch
from
e942ba8 to
b214aa0
Compare
mihai-albu-sage
force-pushed
the
FE-7511
branch
2 times, most recently
from
8514939 to
2eb56c4
Compare
DipperTheDan
reviewed
May 1, 2026
Contributor
DipperTheDan
left a comment
DipperTheDan
left a comment
There was a problem hiding this comment.
Good work, @mihai-albu-sage 😄
For me, I think you might be able to get away with not having to do a __next__ component as the changes aren't too bad. They're about the same as I did with Switch and I was able to avoid the __next__ approach. I am more than happy for a second reviewer to pitch in on this though.
mihai-albu-sage
force-pushed
the
FE-7511
branch
3 times, most recently
from
8d7c250 to
b6c1bb5
Compare
edleeks87
reviewed
May 8, 2026
mihai-albu-sage
force-pushed
the
FE-7511
branch
2 times, most recently
from
bfdffe6 to
d3c5bb5
Compare
DipperTheDan
previously approved these changes
May 12, 2026
edleeks87
previously approved these changes
May 13, 2026
clairedenning
left a comment
clairedenning
left a comment
There was a problem hiding this comment.
Please reply to all comments so that I can learn if my comments aren't relevant. Thanks
mihai-albu-sage
dismissed stale reviews from edleeks87 and DipperTheDan
via
7bc8436
mihai-albu-sage
force-pushed
the
FE-7511
branch
2 times, most recently
from
aa23f9c to
ce466f5
Compare
clairedenning
approved these changes
May 19, 2026
edleeks87
approved these changes
May 19, 2026
DipperTheDan
approved these changes
May 20, 2026
dariusbercea-sage
approved these changes
May 26, 2026
Collaborator
|
🎉 This PR is included in version 159.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
The following changes have been introduced:
darkBackgroundpropbackgroundColorforegroundColorvariantprop. Thevarianttakes precedence over the deprecated styling props (darkBackgrodund,backgroundColor,foregroundColor)Current behaviour
The current component is not aligned with the Fusion DS.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
/docs/deprecated-portrait--docs/docs/portrait--docs