Skip to content

test(step-flow): refine testing suite#7950

Merged
divyajindel merged 2 commits into
masterfrom
FE-6512-step-flow
May 28, 2026
Merged

test(step-flow): refine testing suite#7950
divyajindel merged 2 commits into
masterfrom
FE-6512-step-flow

Conversation

@divyajindel

Copy link
Copy Markdown
Contributor

Proposed behaviour

Removes a number of Playwright tests that duplicate either Jest or Chromatic ones for the 'Step-flow' component

Current behaviour

There are a number of tests that exist in different forms in all the testing suites we do(Jest, Playwright, Chromatic) which cause a prolonged time of execution for no additional value.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

This should decrease the time of execution without compromising testing and coverage

Testing instructions

Make sure the Playwright tests pass

@divyajindel divyajindel self-assigned this May 8, 2026
@divyajindel divyajindel requested review from a team as code owners May 8, 2026 12:01
@divyajindel divyajindel marked this pull request as draft May 8, 2026 12:01
@divyajindel divyajindel marked this pull request as ready for review May 12, 2026 14:11
@divyajindel divyajindel marked this pull request as draft May 12, 2026 15:07
Comment thread src/components/step-flow/step-flow-interaction.stories.tsx Outdated
Comment thread src/components/step-flow/step-flow.test.tsx Outdated
Comment thread src/components/step-flow/step-flow.test.tsx Outdated
@divyajindel divyajindel force-pushed the FE-6512-step-flow branch 2 times, most recently from 07789f7 to cb68eb1 Compare May 19, 2026 10:36
nuria1110
nuria1110 previously approved these changes May 19, 2026
@tomdavies73 tomdavies73 self-requested a review May 19, 2026 12:41
Comment thread src/components/step-flow/step-flow.pw.tsx
await checkAccessibility(page);
});

test("should pass accessibility checks when 'showProgressIndicator' is true", async ({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: you've got a test here still which is just checking if showProgressIndicator is true, but there's also a combo test below which also includes a show progress indicator in all of available steps, so this test can be deleted too.

@paulrobinson88 paulrobinson88 self-requested a review May 28, 2026 09:14
@divyajindel divyajindel marked this pull request as ready for review May 28, 2026 11:52
@divyajindel divyajindel merged commit 4828eb0 into master May 28, 2026
30 checks passed
@divyajindel divyajindel deleted the FE-6512-step-flow branch May 28, 2026 12:04
@carbonci

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 159.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants