test(step-flow): refine testing suite#7950
Merged
Merged
Conversation
06fcabe to
1fa0a5a
Compare
nuria1110
reviewed
May 15, 2026
07789f7 to
cb68eb1
Compare
nuria1110
previously approved these changes
May 19, 2026
tomdavies73
reviewed
May 19, 2026
cb68eb1 to
a23bb0b
Compare
tomdavies73
reviewed
May 20, 2026
| await checkAccessibility(page); | ||
| }); | ||
|
|
||
| test("should pass accessibility checks when 'showProgressIndicator' is true", async ({ |
Contributor
There was a problem hiding this comment.
suggestion: you've got a test here still which is just checking if showProgressIndicator is true, but there's also a combo test below which also includes a show progress indicator in all of available steps, so this test can be deleted too.
a23bb0b to
9d41f92
Compare
tomdavies73
approved these changes
May 20, 2026
nuria1110
approved these changes
May 20, 2026
paulrobinson88
approved these changes
May 28, 2026
Collaborator
|
🎉 This PR is included in version 159.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Removes a number of Playwright tests that duplicate either Jest or Chromatic ones for the 'Step-flow' component
Current behaviour
There are a number of tests that exist in different forms in all the testing suites we do(Jest, Playwright, Chromatic) which cause a prolonged time of execution for no additional value.
Checklist
d.tsfile added or updated if requiredQA
Additional context
This should decrease the time of execution without compromising testing and coverage
Testing instructions
Make sure the Playwright tests pass