Skip to content

feat(decimal): align component with fusion DS - FE-7146#7965

Draft
DipperTheDan wants to merge 1 commit into
masterfrom
FE-7146_decimal-ds-audit
Draft

feat(decimal): align component with fusion DS - FE-7146#7965
DipperTheDan wants to merge 1 commit into
masterfrom
FE-7146_decimal-ds-audit

Conversation

@DipperTheDan
Copy link
Copy Markdown
Contributor

@DipperTheDan DipperTheDan commented May 18, 2026

Proposed behaviour

Updates Decimal to be inline with that of the Fusion DS.

  • Add suffix prop
  • Add PopoverContainer support
  • Add PopoverPosition support
Screenshot 2026-05-18 at 15 50 13 Screenshot 2026-05-18 at 15 48 40 Screenshot 2026-05-18 at 15 49 38 Screenshot 2026-05-18 at 15 50 35

Current behaviour

Decimal is out of date with Fusion DS

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

N/A

Testing instructions

  • Component should match designs on the associated ticket.
  • No functional regressions should occur due to this work.

Comment on lines +262 to +263
document.activeElement !== localRef.current &&
(ev.currentTarget as HTMLElement).contains(ev.target as Node)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have had to change this code as when the Decimal component had PopoverContainerContent that included a Select, clicking on the Select textbox focused the Decimal input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant