Bad handling of VK_ERROR_OUT_OF_DATE_KHR returned from vkAcquireNextImageKHR

[michoecho]

Currently (permalink), if vkAcquireNextImageKHR returns VK_ERROR_OUT_OF_DATE_KHR, the tutorial code reacts by setting updateSwapchain = true (so that the swapchain is recreated at a later time) and proceeds as usual.

That would be appropriate for VK_SUBOPTIMAL_KHR, but it's not appropriate for VK_ERROR_OUT_OF_DATE_KHR.
VK_ERROR_OUT_OF_DATE_KHR is a failure. The spec says:

If VK_ERROR_OUT_OF_DATE_KHR is returned, no image is acquired

and also

If vkAcquireNextImageKHR does not successfully acquire an image, semaphore and fence are unaffected.

So if vkAcquireNextImageKHR returns VK_ERROR_OUT_OF_DATE_KHR, the main loop is going to break down in some weird way. Presumably it will deadlock, because the presentSemaphores[frameIndex] is never going to be signalled, so the vkQueueSubmit will wait forever on it.

[radgeRayden]

I don't have the time right now to make the necessary changes to the tutorial text, but I handled this in radgeRayden@c6f25b2 by:

• moving the event loop to the beginning of the frame, so we can fix the swapchain on resizes right away. This is necessary on some setups (such as the niri window compositor) where the windows may not immediately start at their correct size. I'm not entirely sure why this is necessary but it will deadlock unless I do the checking before trying to acquire the first image. I suspect there is something about the window initialization in SDL that doesn't like doing things before the first successful present.
• Not resetting the fence unless we successfully acquired the image. This is mentioned in the vulkan-tutorial, and directly addresses this issue.

[fixgoats]

Seconded, this may not cause problems on most devices, but on devices that give you a double buffered swapchain instead of triple buffered by default this means some semaphores cannot be signaled after resizing and the program hangs. specifically you get these validation errors https://vulkan.lunarg.com/doc/view/1.4.335.0/linux/antora/spec/latest/chapters/cmdbuffers.html#VUID-vkQueueSubmit-pWaitSemaphores-03238 and https://vulkan.lunarg.com/doc/view/1.4.335.0/linux/antora/spec/latest/chapters/VK_KHR_surface/wsi.html#VUID-VkPresentInfoKHR-pImageIndices-01430