Repository navigation
Keep polyhedron editing and analysis available when the overlay is off - #235
Merged
Merged
Conversation
Row checkboxes still decide which specs draw. The overlay switch only hides the layer, and analysis computes from existing specs without flipping that switch. Co-authored-by: Ming-Yu Guo <guomy26@mail2.sysu.edu.cn>
SchrodingersCattt
left a comment
SchrodingersCattt
left a comment
Owner
Author
There was a problem hiding this comment.
Review (Part of #228)
Verdict: approve-ready
What it does
Keeps polyhedron editing and analysis available when the topology overlay is off — analysis no longer gated solely by topology_enabled (medium #228).
CI
9/9 green on 4bca28c.
Notes
- Correct product behavior: overlay visibility ≠ capability gate.
- Low conflict risk with the transform/projection batch; can merge independently.
- No merge from me (author PR).
10 of 12 tasks
SchrodingersCattt
left a comment
SchrodingersCattt
left a comment
Owner
Author
There was a problem hiding this comment.
Re-review (Part of #228)
Verdict: approve-ready (head advanced past prior review on 4bca28c6)
Follow-up 912fa5a: keeps overlay drawing gates separate across analysis and view updates — view_updates.js now ANDs topology_enabled with per-spec enabled; docs/POST /topology wording matches analysis-with-drawing-off. Extra tests for MVF acceptance + topology API. CI 9/9. Still approve-ready; can land independently.
No merge from me (author PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #228
The polyhedron editor stays visible when “Show polyhedra overlay” is off, so color, row visibility, and centre/ligand fields can still be edited. A row’s
enabledflag decides whether that spec is drawn.topology_enabledremains the overlay switch used when the figure is assembled, and it no longer forces every row off.run_analysiscomputes whenever specs exist. It does not returndisabledbecause the overlay is off, and it does not write the overlay flag back onto the scene. With no specs the status is stillno_specs.