Revert "Fix inference issue in Rosenbrock DAE test"

[ChrisRackauckas]

Reverts #2931

[github-actions]

Benchmark Results (Julia v1)

Time benchmarks

	master	d713177...	master / d713177...
construction/linear_N50	26.9 ± 2 μs	27.2 ± 1.6 μs	0.989 ± 0.094
construction/lotka_volterra	18 ± 0.27 μs	18.1 ± 0.28 μs	0.995 ± 0.022
construction/rober	18 ± 0.3 μs	18.1 ± 0.25 μs	0.991 ± 0.021
nonstiff/fitzhugh_nagumo/BS3	0.131 ± 0.04 ms	0.134 ± 0.04 ms	0.98 ± 0.42
nonstiff/fitzhugh_nagumo/DP5	0.0906 ± 0.031 ms	0.0931 ± 0.033 ms	0.973 ± 0.48
nonstiff/fitzhugh_nagumo/Tsit5	0.107 ± 0.045 ms	0.101 ± 0.045 ms	1.05 ± 0.64
nonstiff/fitzhugh_nagumo/Vern6	0.117 ± 0.05 ms	0.117 ± 0.05 ms	0.998 ± 0.61
nonstiff/fitzhugh_nagumo/Vern7	0.0992 ± 0.047 ms	0.0991 ± 0.046 ms	1 ± 0.66
nonstiff/lotka_volterra/BS3	0.267 ± 0.013 ms	0.26 ± 0.012 ms	1.03 ± 0.068
nonstiff/lotka_volterra/DP5	0.0439 ± 0.016 ms	0.0432 ± 0.016 ms	1.02 ± 0.53
nonstiff/lotka_volterra/Tsit5	0.0575 ± 0.028 ms	0.056 ± 0.028 ms	1.03 ± 0.71
nonstiff/lotka_volterra/Vern6	0.0765 ± 0.028 ms	0.0709 ± 0.028 ms	1.08 ± 0.58
nonstiff/lotka_volterra/Vern7	0.0594 ± 0.023 ms	0.06 ± 0.022 ms	0.991 ± 0.53
nonstiff/pleiades/BS3	0.0854 ± 0.023 s	0.0842 ± 0.025 s	1.02 ± 0.41
nonstiff/pleiades/DP5	1.23 ± 0.16 ms	1.28 ± 0.2 ms	0.957 ± 0.19
nonstiff/pleiades/Tsit5	14.6 ± 7.9 ms	14.8 ± 7.8 ms	0.992 ± 0.75
nonstiff/pleiades/Vern6	6.71 s	6.79 s	0.988
nonstiff/pleiades/Vern7	7.87 s	7.96 s	0.989
scaling/brusselator_2d/16x16	0.321 ± 0.018 s	0.325 ± 0.025 s	0.99 ± 0.094
scaling/brusselator_2d/32x32	7.61 s	7.61 s	1
scaling/brusselator_2d/8x8	12.3 ± 1.5 ms	12.1 ± 1.2 ms	1.01 ± 0.16
scaling/linear/N10	0.0371 ± 0.017 ms	0.0363 ± 0.017 ms	1.02 ± 0.67
scaling/linear/N100	0.816 ± 0.018 ms	0.814 ± 0.017 ms	1 ± 0.03
scaling/linear/N50	0.211 ± 0.011 ms	0.212 ± 0.013 ms	0.994 ± 0.08
stiff/pollution/FBDF	0.6 ± 0.016 ms	0.6 ± 0.014 ms	1 ± 0.035
stiff/pollution/KenCarp4	0.551 ± 0.013 ms	0.552 ± 0.013 ms	0.999 ± 0.032
stiff/pollution/Rodas4	0.785 ± 0.017 ms	0.787 ± 0.015 ms	0.997 ± 0.029
stiff/pollution/Rosenbrock23	1.38 ± 0.027 ms	1.38 ± 0.029 ms	0.998 ± 0.029
stiff/pollution/TRBDF2	0.518 ± 0.015 ms	0.514 ± 0.014 ms	1.01 ± 0.039
stiff/rober/FBDF	0.591 ± 0.039 ms	0.591 ± 0.039 ms	1 ± 0.092
stiff/rober/KenCarp4	0.695 ± 0.022 ms	0.7 ± 0.021 ms	0.994 ± 0.043
stiff/rober/Rodas4	0.369 ± 0.028 ms	0.368 ± 0.028 ms	1 ± 0.11
stiff/rober/Rosenbrock23	0.258 ± 0.03 ms	0.268 ± 0.031 ms	0.961 ± 0.16
stiff/rober/TRBDF2	1.62 ± 0.094 ms	1.62 ± 0.091 ms	1 ± 0.081
stiff/van_der_pol/FBDF	9.49 ± 0.56 ms	9.5 ± 0.59 ms	0.998 ± 0.085
stiff/van_der_pol/KenCarp4	4.49 ± 0.042 ms	4.52 ± 0.048 ms	0.992 ± 0.014
stiff/van_der_pol/Rodas4	6.84 ± 0.18 ms	6.66 ± 0.13 ms	1.03 ± 0.034
stiff/van_der_pol/Rosenbrock23	20.1 ± 0.37 ms	20.2 ± 0.63 ms	0.995 ± 0.036
stiff/van_der_pol/TRBDF2	2.86 ± 0.062 ms	2.84 ± 0.066 ms	1.01 ± 0.032
time_to_load	3.63 ± 0.06 s	3.6 ± 0.072 s	1.01 ± 0.026

Memory benchmarks

	master	d713177...	master / d713177...
construction/linear_N50	0.069 k allocs: 0.041 MB	0.069 k allocs: 0.041 MB	1
construction/lotka_volterra	0.063 k allocs: 2.36 kB	0.063 k allocs: 2.36 kB	1
construction/rober	0.063 k allocs: 2.33 kB	0.063 k allocs: 2.33 kB	1
nonstiff/fitzhugh_nagumo/BS3	3.67 k allocs: 0.158 MB	3.67 k allocs: 0.158 MB	1
nonstiff/fitzhugh_nagumo/DP5	2.62 k allocs: 0.121 MB	2.62 k allocs: 0.121 MB	1
nonstiff/fitzhugh_nagumo/Tsit5	3.98 k allocs: 0.177 MB	3.98 k allocs: 0.177 MB	1
nonstiff/fitzhugh_nagumo/Vern6	4.52 k allocs: 0.202 MB	4.52 k allocs: 0.202 MB	1
nonstiff/fitzhugh_nagumo/Vern7	3.9 k allocs: 0.176 MB	3.9 k allocs: 0.176 MB	1
nonstiff/lotka_volterra/BS3	7.86 k allocs: 0.35 MB	7.86 k allocs: 0.35 MB	1
nonstiff/lotka_volterra/DP5	1.2 k allocs: 0.0524 MB	1.2 k allocs: 0.0524 MB	1
nonstiff/lotka_volterra/Tsit5	2.16 k allocs: 0.0912 MB	2.16 k allocs: 0.0912 MB	1
nonstiff/lotka_volterra/Vern6	2.23 k allocs: 0.0967 MB	2.23 k allocs: 0.0967 MB	1
nonstiff/lotka_volterra/Vern7	1.63 k allocs: 0.0718 MB	1.63 k allocs: 0.0718 MB	1
nonstiff/pleiades/BS3	0.685 M allocs: 0.0673 GB	0.685 M allocs: 0.0673 GB	1
nonstiff/pleiades/DP5	6.65 k allocs: 0.509 MB	6.65 k allocs: 0.509 MB	1
nonstiff/pleiades/Tsit5	0.186 M allocs: 20.2 MB	0.186 M allocs: 20.2 MB	1
nonstiff/pleiades/Vern6	0.038 G allocs: 4.08 GB	0.038 G allocs: 4.08 GB	1
nonstiff/pleiades/Vern7	0.044 G allocs: 4.66 GB	0.044 G allocs: 4.66 GB	1
scaling/brusselator_2d/16x16	3.58 k allocs: 0.152 GB	3.58 k allocs: 0.152 GB	1
scaling/brusselator_2d/32x32	3.39 k allocs: 2.22 GB	3.39 k allocs: 2.22 GB	1
scaling/brusselator_2d/8x8	2.62 k allocs: 8.76 MB	2.62 k allocs: 8.76 MB	1
scaling/linear/N10	0.751 k allocs: 0.0513 MB	0.751 k allocs: 0.0513 MB	1
scaling/linear/N100	2.27 k allocs: 0.899 MB	2.27 k allocs: 0.899 MB	1
scaling/linear/N50	1.65 k allocs: 0.346 MB	1.65 k allocs: 0.346 MB	1
stiff/pollution/FBDF	1.51 k allocs: 0.287 MB	1.51 k allocs: 0.287 MB	1
stiff/pollution/KenCarp4	0.514 k allocs: 0.134 MB	0.514 k allocs: 0.134 MB	1
stiff/pollution/Rodas4	1.28 k allocs: 0.363 MB	1.28 k allocs: 0.363 MB	1
stiff/pollution/Rosenbrock23	2.77 k allocs: 0.817 MB	2.77 k allocs: 0.817 MB	1
stiff/pollution/TRBDF2	0.781 k allocs: 0.166 MB	0.781 k allocs: 0.166 MB	1
stiff/rober/FBDF	2.88 k allocs: 0.132 MB	2.88 k allocs: 0.132 MB	1
stiff/rober/KenCarp4	1.29 k allocs: 0.0556 MB	1.29 k allocs: 0.0556 MB	1
stiff/rober/Rodas4	2.18 k allocs: 0.104 MB	2.18 k allocs: 0.104 MB	1
stiff/rober/Rosenbrock23	2.49 k allocs: 0.116 MB	2.49 k allocs: 0.116 MB	1
stiff/rober/TRBDF2	7.7 k allocs: 0.344 MB	7.7 k allocs: 0.344 MB	1
stiff/van_der_pol/FBDF	0.0443 M allocs: 2.01 MB	0.0443 M allocs: 2.01 MB	1
stiff/van_der_pol/KenCarp4	4.27 k allocs: 0.185 MB	4.27 k allocs: 0.185 MB	1
stiff/van_der_pol/Rodas4	0.0377 M allocs: 1.74 MB	0.0377 M allocs: 1.74 MB	1
stiff/van_der_pol/Rosenbrock23	0.213 M allocs: 9.51 MB	0.213 M allocs: 9.51 MB	1
stiff/van_der_pol/TRBDF2	5.02 k allocs: 0.245 MB	5.02 k allocs: 0.245 MB	1
time_to_load	0.145 k allocs: 11 kB	0.145 k allocs: 11 kB	1

[oscardssmith]

why revert?

[ChrisRackauckas]

This wasn't necessary for the test fixes I am working through. These changes could be fine in the future but it just wasn't related to the actual inference issue and I'm just keeping focused on that.