Skip to content

Add ExplicitImports.jl tests to CI#207

Merged
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:explicit-imports-20251229-111436
Dec 29, 2025
Merged

Add ExplicitImports.jl tests to CI#207
ChrisRackauckas merged 1 commit into
SciML:mainfrom
ChrisRackauckas-Claude:explicit-imports-20251229-111436

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Contributor

Summary

  • RootedTrees.jl already passes all ExplicitImports checks (no implicit imports, no stale explicit imports)
  • Added ExplicitImports.jl tests to CI to maintain import hygiene going forward
  • Added ExplicitImports to test dependencies in test/Project.toml
  • Added ExplicitImports testset to test/runtests.jl

Changes

test/Project.toml:

  • Added ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7" to [deps]
  • Added ExplicitImports = "1" to [compat]

test/runtests.jl:

  • Added import: using ExplicitImports: check_no_implicit_imports, check_no_stale_explicit_imports
  • Added testset:
@testset "ExplicitImports" begin
    @test isnothing(check_no_implicit_imports(RootedTrees))
    @test isnothing(check_no_stale_explicit_imports(RootedTrees))
end

Test plan

  • Run Pkg.test() locally - all tests pass (580,749 tests passed)
  • ExplicitImports checks pass

cc @ChrisRackauckas

🤖 Generated with Claude Code

RootedTrees.jl already passes all ExplicitImports checks (no implicit
imports, no stale explicit imports). This PR adds the ExplicitImports.jl
tests to CI to ensure this hygiene is maintained going forward.

Changes:
- Add ExplicitImports to test dependencies
- Add ExplicitImports testset to runtests.jl

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@ChrisRackauckas ChrisRackauckas merged commit 3700d5b into SciML:main Dec 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants