fix(#319): Intf_Interference O(1) tangent-zone + checkpoint breaker — v1.15.1 - #337
Merged
Conversation
…aker patch Local carry of Open-Cascade-SAS/OCCT#1386 (CI green, ready for review), fixing the isSelfIntersecting hardTimeout: hang on pathological self-interference artifacts. Xcframework rebuild + release to follow. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…(patch 0010) CLAUDE.md Known OCCT Bugs entry, CHANGELOG v1.15.1 entry, and the okf carried-patches reference table. Package.swift binaryTarget comment lists patch 0010; URL/checksum bump follows once the xcframework rebuild finishes and is uploaded. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…) + checkpoint breaker) Full 3-slice rebuild verified against occt-src's current patch set (10 patches, including 0010 for #319). swift build/test green: 4415 tests, 1278 suites. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isSelfIntersecting(hardTimeout:)being unable to interrupt a stuck self-interference search on a pathological artifact (619s+ CPU against a 30s deadline, never returning).Intf_Interference::InsertcallingIntf_TangentZone::GetPoint(Index)(O(n) per call, no O(1) indexed access) inside a nested comparison loop, plus a total lack of a progress checkpoint belowBOPAlgo_CheckerSI::CheckFaceSelfIntersection.Scripts/patches/0010-Intf_Interference-O1-tangent-zone-checkpoint-breaker-319.patch:Intf_TangentZone::Points()caches a random-access array per zone;Intf_Interference::SetBreaker(thread-local, RAII-scoped) letsInsert()poll aMessage_ProgressScopeevery 256 calls and abort, wired intoBOPAlgo_CheckerSI's self-intersect functor when single-threaded.Scripts/repro/319-selfintersection/.Package.swiftbumped to the v1.15.1 binary release.CLAUDE.mdKnown OCCT Bugs,docs/CHANGELOG.md,Scripts/patches/README.md,okf/references/carried-occt-patches.md.Test plan
HasFaulty()results at every deadline tested (0.5s/1s/2s/3s/5s/30s), clean across a 10x repeated-run stress testIntf_TangentZone_Test.cxx,Intf_Interference_Test.cxx) pass on Linux/Windows/macOS in OCCT's own CIswift build/swift testgreen against the rebuilt xcframework: 4415 tests, 1278 suites🤖 Generated with Claude Code