-
Notifications
You must be signed in to change notification settings - Fork 3
docs: transcribe eleven CHANGELOG entries that never left their PR bodies #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gsdali
merged 2 commits into
refactor/381-pass1b
from
docs/transcribe-untranscribed-changelog
Aug 8, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanup (confirmed):
okf/policies/changelog-on-merge.mdstates: "A pull request must not modify the## Unreleasedsection ofdocs/CHANGELOG.md. It carries its entry in the PR body instead... Do not touchdocs/CHANGELOG.md. If your diff contains it, that is a review finding." The only stated exceptions are the release commit (rewrites the whole section) and "a PR that fixes the CHANGELOG itself, for instance a stale cross-reference" — which is not adding an entry. This PR's diff inserts ~190 lines of eleven brand-new entries directly into## Unreleasedstarting here, which is adding entries, not a small self-correcting fix like the cited example. I recognize the PR body frames this as a deliberate release-prep catch-up (transcribing entries that were dropped at merge time), which is a reasonable rationale — but per the letter of the policy this is still a review finding, and if any other in-flight PR also touches## Unreleasedaround when this merges (the policy notes the branch "routinely has six or more" PRs open), this large insertion recreates exactly the merge-conflict cost the policy exists to avoid. Worth confirming intentionally whether this counts as an accepted exception, or whether the eleven entries should land some other way (e.g. via the release commit itself).