docs: transcribe #943's CHANGELOG entry and add its v3.0.0 SemVer break - #947
Merged
Conversation
PR #944 merged without either. The entry existed in its PR body and was never copied across; the SemVer row could not be, because semver-at-release forbids a PR touching docs/SEMVER.md, so the row is written here as the merging step. Without this, v3.0.0 would have shipped a break table listing only #844 while six accessors became Optional -- Shape.bounds/size/center, Wire.bounds, Edge.bounds and Face.bounds, a compile error for every caller and the break a consumer is most likely to hit. That is exactly #829: v2.0.0 shipped omitting #595 from its table, a downstream consumer (swiftGCS) hit an unpredicted compile error, and we corrected it four days ago. The same gap, one release later, from the same cause: a break whose row nobody wrote at merge. The v3.0.0 intro said the major was "carried by a single merged change", which is no longer true; it now names both. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by nemotron-3-ultra-550b-a55b:free · Input: 218K · Output: 1.7K · Cached: 336.6K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
PR #944 (#943) merged without its CHANGELOG entry and without its SemVer break row. This adds both.
check-changelog-transcription.py --verify-transcribedonmainreports it:882a2ddb #944under "entry in the PR body, NOT in the CHANGELOG".semver-at-releaseforbids a PR touchingdocs/SEMVER.md. Writing it is the merging step, and it was missed.What would have shipped
docs/SEMVER.md's v3.0.0 break table listed only #844 — an enum rename and aRawValuechange. Meanwhile six accessors had become Optional onmain:Shape.bounds,Shape.size,Shape.center,Wire.bounds,Edge.bounds,Face.boundsThat is a compile error for every caller, and it is the break a consumer is most likely to hit, because
bounds,sizeandcenterget read casually.This is #829 repeating. v2.0.0 shipped with #595 missing from its break table; a real downstream consumer (swiftGCS) hit a compile error that reading the table could not have predicted; we corrected it four days ago in PR #939. Same gap, one release later, same cause: a break whose row nobody wrote at merge time.
Changes
docs/CHANGELOG.md: Breaking: Shape.bounds becomes Optional, so a void shape stops fabricating (0,0,0)-(0,0,0) (follow-up to #834) #943's entry, transcribed from fix(#943): make Shape.bounds Optional for v3.0.0 breaking change #944's body and expanded slightly with the root cause the PR established —occtComputeBoundingBoxbeing file-static inOCCTBridge_Topology.mmis whyOCCTShapeGetBounds, over inOCCTBridge_Properties.mm, was the one bounds entry point with no guard.docs/SEMVER.md: a third row in the v3.0.0 table, and a##### v3.0.0: bounds, size and center become Optional (#943)subsection with the full before/after table and a migration snippet.The subsection records the measured reason a value-based test was rejected: a vertex at the world origin measures exactly
(0,0,0)-(0,0,0)throughBRepBndLib::AddOptimal, so inferring "void" from the coordinates is the same fabrication relocated. Through ordinaryBRepBndLib::Addthe same vertex measures±1e-7, becauseBRep_Tool::Tolerancefloors atPrecision::Confusion()— so a sentinel would have misfired on one path and not the other. Both fromScripts/repro/943-bounds-void-vs-zero/.Verification
All seven gate scripts run clean, including
check-changelog-transcription.py, which no longer reports #944.CHANGELOG entry
None. This PR is the transcription; per
changelog-on-mergea PR whose only purpose is to write an entry from another PR's body is the merger doing their job, and it is the only open PR touching either file.SemVer impact
NONE in itself. Documentation only. It documents a break that already landed in #944; it does not introduce one.