ci: run swift build and swift test on every push and PR - #57
Merged
Conversation
This repo carried a full test suite that no CI job ever executed, so a failing test produced a green tick. Recorded fleet-wide as ecosystem#40, where 12 of the 14 repos in the OCCT stack had the same gap. swift build and swift test are separate steps deliberately: swift build does not compile test targets, so on its own it is a weaker signal than it appears. Baseline measured locally before rollout.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| run: swift build | ||
|
|
||
| - name: swift test | ||
| run: swift test |
There was a problem hiding this comment.
CRITICAL: Missing required OCCT_SERIAL=1 and serial test flags
The CLAUDE.md explicitly states: OCCT_SERIAL=1 swift test --parallel --num-workers 1 # MUST run serially — there is a known NCollection container-overflow race in OCCT on arm64 macOS that segfaults parallel test runs. The workflow runs on macos-15 (arm64), so swift test without these flags will likely segfault.
Suggested change
| run: swift test | |
| - name: swift test | |
| run: OCCT_SERIAL=1 swift test --parallel --num-workers 1 |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (1 files)
Fix these issues in Kilo Cloud Reviewed by nemotron-3-ultra-550b-a55b:free · Input: 83.6K · Output: 2.1K · Cached: 38.9K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a blocking
testsworkflow runningswift buildthenswift teston every push and PR.Part of the fleet-wide rollout in ecosystem#40: 12 of the 14 repos in the OCCT stack ran no tests in CI at all, so a failing test produced a green tick. This repo was one of them.
That gap is not hypothetical. Five assertions in OCCTSwiftAIS sat broken for nine days (OCCTSwiftAIS#46) because nothing in its pipeline ever compiled a test target.
swift buildandswift testare separate steps on purpose.swift builddoes not compile test targets, so it is a weaker signal than it looks: OCCTSwiftIO built clean with zero errors while carrying three real breaks in its test target during the OCCTSwift v3.0.0 repin.Modelled on
OCCTSwiftScripts/.github/workflows/tests.yml, which already solved this once:macos-15,actions/cacheon.buildkeyed byPackage.resolved, blocking rather thancontinue-on-error.Baseline was measured locally before rollout rather than assumed. See the workflow's own header comment for this repo's count.
Notes for the reviewer
Nothing but the workflow file is added. No source, manifest or doc change.