Tweak the test standards skill and project convention - #135
Merged
Merged
Conversation
The Testing standard paired every malformed case with its own Control case and was read as one named test per guard plus one per control. A guard family is now one table-driven test with an accepting row as its control; a branch earns its own test only with its own spec citation or failure mode. Tests assert on outcomes rather than log wording, and reach private state only where nothing observable distinguishes the correct path. The skill checklist flags the same.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Updates testing standards to favor table-driven validation tests and behavior-focused assertions.
Changes:
- Groups related guards with accepting control rows.
- Discourages brittle log assertions and unnecessary private-state checks.
- Aligns project conventions with the test-standards skill.
| File | Description |
|---|---|
docs/conventions.md |
Updates normative testing conventions. |
.claude/skills/test-standards/SKILL.md |
Aligns the review checklist with those conventions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kahrendt
enabled auto-merge (squash)
September 29, 2026 11:56
kahrendt
disabled auto-merge
September 29, 2026 11:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Testing standard paired every malformed case with its own Control case and was read as one named test per guard plus one per control. A guard family is now one table-driven test with an accepting row as its control; a branch earns its own test only with its own spec citation or failure mode. Tests assert on outcomes rather than log wording, and reach private state only where nothing observable distinguishes the correct path. The skill checklist flags the same.