Skip to content

refactor: clarify reconciliation input semantics - #10

Merged
SerDrozd merged 1 commit into
mainfrom
refactor/reconciliation-semantics
Oct 4, 2026
Merged

SerDrozd merged 1 commit into
mainfrom
refactor/reconciliation-semantics

Conversation

@SerDrozd

@SerDrozd SerDrozd commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Summary

Clarify the internal input model now that RowBridge supports both CSV and XLSX files, and lock in the current one-to-one resolution behavior with a regression test.

Changes

  • rename the internal CsvTable model to InputTable
  • keep CsvTable as a compatibility alias for existing imports
  • remove the unused CsvInputError compatibility alias and development comment
  • update internal type hints and architecture documentation
  • add a regression test showing that one-to-one resolution is score-ordered greedy rather than a global assignment optimizer

Validation

  • uv run ruff check .
  • uv run mypy src tests
  • uv run pytest - 59 passed
  • git diff --check

@SerDrozd
SerDrozd merged commit f740309 into main Oct 4, 2026
5 checks passed
@SerDrozd
SerDrozd deleted the refactor/reconciliation-semantics branch October 4, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant