Skip to content

fix: harden matching correctness - #6

Merged
SerDrozd merged 5 commits into
mainfrom
fix/matching-correctness
Oct 3, 2026
Merged

SerDrozd merged 5 commits into
mainfrom
fix/matching-correctness

Conversation

@SerDrozd

@SerDrozd SerDrozd commented Oct 3, 2026

Copy link
Copy Markdown
Owner

Summary

Fix several correctness issues in matching and runtime version reporting.

Changes

  • derive the runtime version from package metadata instead of duplicating it in application code
  • preserve Unicode letters during text normalization
  • parse Excel-style datetime values correctly during date matching
  • support common US and European amount formats
  • preserve accounting-style negative amounts
  • keep the documented base matching weights when optional rules are omitted, then normalize the active rules
  • add regression coverage for the corrected cases

Validation

  • uv run ruff check .
  • uv run mypy src tests
  • uv run pytest — 50 passed
  • uv build
  • git diff --check

@SerDrozd
SerDrozd merged commit b0fa140 into main Oct 3, 2026
5 checks passed
@SerDrozd
SerDrozd deleted the fix/matching-correctness branch October 3, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant