Use Rc<HashSet> for parent_fragments to avoid cloning in field selection merging#87
Draft
davejcameron wants to merge 1 commit intomainfrom
Draft
Use Rc<HashSet> for parent_fragments to avoid cloning in field selection merging#87davejcameron wants to merge 1 commit intomainfrom
davejcameron wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
HashSet<&'a str>withRc<HashSet<&'a str>>for theparent_fragmentsfield inFieldContext. This eliminates O(n) HashSet cloning for every field - field contexts now share the same HashSet via reference counting, and only fragment spreads (which need to add entries) create new HashSets.Benchmark Results
The 1-field case has slight overhead from Rc allocation, but this is amortized across multiple fields which is the common case in real queries.
Test plan