Repository navigation
Conversation
dalehamel
force-pushed
the
dale/offcpu-omnibus-upstream-sync
branch
from
July 24, 2026 20:32
7419022 to
9bfba71
Compare
Port the generic Probe/ProbeContext API onto the upstream-synced LuaJIT omnibus base. Add isolated per-probe RODATA, private resource removal, shared latency config/map lifecycle helpers, dynamic metrics collector registration, and label-aware sample identity. This is the minimal runtime required by off_cpu_time; it intentionally excludes all I/O, userspace-target, lock-wait, and process-observer probes. Assisted-By: devx/2d48a84f-4aab-48eb-9009-5dd68fa593f3
dalehamel
force-pushed
the
dale/offcpu-omnibus-probe-api
branch
from
July 24, 2026 20:33
3a279c8 to
30b61c7
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
What
Port the generic
Probe/ProbeContextloading API onto the upstream-synced LuaJIT omnibus base, plus only the reusable runtime capabilities explicitly required byoff_cpu_time:.rodata/.rodata.varmaps per probe instance;<configured name>_*convention;It includes the generic demo probe from Shopify #58, but intentionally excludes every Hack Days I/O, async, process-observer, userspace-target, lock-wait, heap, and off-CPU implementation.
Why these additions to #58
The original #58 API was subsequently hardened by the synchronous probes and process-aware probes.
off_cpu_timeexplicitly depends on isolated RODATA, private-resource unloading,probeutil, metric registration, and label-aware sample keys; extracting these generic pieces avoids depending on #53/#63/#65 wholesale.Omnibus adaptation
PR #50 had one LuaJIT
ProgLoaderHelperliteral using the old private field names. This layer ports it to the exported API (ProgID,Name,Enable) without changing behavior.Validation
go build,go test, andgo vetacross probes, tracer, reporter, traceutil, and controller.