Migrate test discovery to use Rubydex#4064
Open
vinistock wants to merge 1 commit intorubydex_adoption_feature_branchfrom
Open
Migrate test discovery to use Rubydex#4064vinistock wants to merge 1 commit intorubydex_adoption_feature_branchfrom
vinistock wants to merge 1 commit intorubydex_adoption_feature_branchfrom
Conversation
vinistock
added
server
vinistock
commented
Apr 16, 2026
| end | ||
|
|
||
| def test_ignores_minitest_tests_that_extend_active_support_declarative | ||
| skip("[RUBYDEX] Needs extend fix") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Migrate test discovery to use Rubydex.
Implementation
Since Rubydex handles incremental changes immediately on edits, we no longer need the complicated lazy indexing case. We can trust the graph to be up to date.
Automated Tests
There are still some incremental handling weirdness, so I made small adjustments to the tests to avoid it and unblock this migration.