Check deployment checks before CD delayed#1439
Open
timothysmith0609 wants to merge 2 commits intomainfrom
Open
Check deployment checks before CD delayed#1439timothysmith0609 wants to merge 2 commits intomainfrom
timothysmith0609 wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the global lock is active, it appears we are hitting a conditional for
Continuous Delivery Delayed, even though the cause of that is that deploys are locked. In this scenario, we should only display the lock banner and not theContinuous Deliver Delayedbanner, as well.This looks like we just need to change the
if/elsiforder of the check