ThemeKit 1.1.2, support section themes#1071
ThemeKit 1.1.2, support section themes#1071henrybarn wants to merge 2 commits intoShopify:masterfrom
Conversation
|
@henrybarn Are you interested in forking this repo to help make an unofficial toolkit for this? I can be involved, though I'm not the most experienced at all of this, I've built about 100 stores on Slate and would like to have an option moving forward. |
|
@evankford And I've made the following upgrades:
You're welcome to give it a try. You will need to update all babel plugins. You'll need node >= 11.10.1 You'll also to have to upgrade the following devDependencies in your slate project's root directory either with the CLI or by editing
And you'll have to use a Babel 7 compatible |
This repo is currently on low maintenance. See README for details
What are you trying to accomplish with this PR?
Upgrades node-themekit to version 1.1.2
Offers support for section themes with ShopifySlateSections plugin.
Things I considered:
SlateSections now checks if the source directory exists making Slate compatible with both section themes and non section themes.
My last PR had removed the --replace functionality accidentally, that's fixed here
My last PR had an issue with an empty SLATE_IGNORE_FILES in .env, that's fixed here
Please provide a link to the associated GitHub issue.
#1057
#1054
Checklist
For contributors:
For maintainers: