This repository was archived by the owner on Jul 19, 2021. It is now read-only.
Add Linux/Ubuntu ssl-check shell function instructions#1083
Open
tracy-codes wants to merge 5 commits intoShopify:masterfrom
Open
Add Linux/Ubuntu ssl-check shell function instructions#1083tracy-codes wants to merge 5 commits intoShopify:masterfrom
tracy-codes wants to merge 5 commits intoShopify:masterfrom
Conversation
Add a separate function for ssl-check specifically for Linux.
Remove empty space left by my formatter
ghost
added
the
Added a comment for the local_ip variable and the hostname usage
This was referenced Jan 3, 2020
Update shell script to create SSL certificate for all IPs found by `hostname`. This improves accuracy when running ssl-check. For instance, if you have a docker network interface, then sometimes the first IP will actually be the docker IP. The ssl-check function would originally fail because of that. This change resolves that failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Add a Linux-specific ssl-check bash function. The Mac one provided doesn't work on WSL/Ubuntu setups. This Linx-specific function replaces the
local_ipfunctionality with built-in linux tools and still utilizes mkcert.Checklist
For contributors:
For maintainers: