Repository navigation
fix(viewer): finer LOD progress, 4K poster readiness and official branding (5.21.11) - #144
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 408cb5b0-b161-41f2-9e18-2638c7ec2b9b) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 3963f7b0-8cb6-4776-8707-6304101a5eec) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: e895e271-faa7-45f6-81d8-79ae70e8454f) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 47cc0d92-9071-490a-8f36-6402d98f6c6b) |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: d4cd6c13-3659-47bb-90e5-52ac798bebc2) |
结果
初始 LOD 的百分比使用本实例分块 progress/load,包含分块内读取比例,解决 Safari 中只在整块结束后从0跳至14%/28%的现象。保留数字标题、下方分阶段 LOD 提示、常显请求/速率/错误信息和透明无边框样式。
恢复图片可显示后才出现加载 UI 的设计。缓存图片、失败、10秒未完成、场景提前就绪和销毁有明确处理;图片不会阻塞真实场景首帧。缇宝使用保持4096×4096的压缩编码WebP(q82,361,112字节),按用户纠正撤回1024候选、从本次包移除旧无损版本,使用新文件名避免immutable缓存。
左上角收起使用官方 metaflow_logo.svg,展开使用完整 metaflow.svg 组合版;保留原始路径、viewBox、内部间距与相对比例,以图标同尺度呈现。撤回图标+字标拼接候选。保留200ms宽度与淡入淡出动画,桌面hover/键盘focus与WebKit手机首次点击展开通过;中间帧有48→65→80→89→91px的连续变化,失焦反向收起。透明背景、0边框、首页链接保持,嵌入无需品牌资产请求。对照5.19.3恢复明确触屏首击展开/第二击链接:真实WebKit首次点击无新页面,第二次打开原首页URL通过。
范围与兼容
MF-142,risk/T1,viewer/data。唯一轻量计划:Issue #142。验证记录:verification.md。本PR产品发布目标5.21.11,后续回填实际产品SHA/tag/生产部署。Refs #142;保留该Issue到生产观察完成。
100项/schema1.2保持;仅缇宝thumbnail、大小和updatedIn调整,其他99条资源记录完全一致;模型/settings/环境/体素/路线、引擎、Editor/Director不改。未知总量不伪造读取比例,百分比单调并限定99,场景就绪才100。只观察引擎事件,无新的模型下载或内容缓冲;完成/销毁/初始化失败清理。
实际验证
本地慢速服务器的 Chromium 报 scene.sog ERR_ABORTED,但单请求读取完成(10,563,265字节)、SHA-256与发布模型fadd3649484d71533e421b511808fce062d705c5d82ef11a218657754e4913f6完全一致,ZIP解码和首帧正常;仍记录网络事件异常,正式候选使用严格请求检查。
限制、失败与回退
受控网络不代表用户真实弱网;未做iOS/iPadOS真机。引擎loose SOG进度合并纹理总量,整体是初始分块工作进度,不宣称已知全场景字节分母。未新增settings/响应体全链路重试。已有三项间接依赖audit告警随基线保持,详见MF-139。
CI38041561032 的构建/E2E通过,版本覆盖指出f128450 CSS格式提交漏登维护来源,登记实际SHA及Ledger后重跑,保留断言。CI38040250845 的 Viewer/数据/文档/CodeQL通过,治理检查指出版本 trace 缺少 PR 链接;补齐真实 PR144,重新运行完整CI。Cursor/Copilot自动审查额度不足,未称其已审查。初次版本检查发现重复候选entry,修正为唯一5.21.11并登记来源后通过;导入顺序lint前向修正;系统临时目录ENOSPC导致publint失败,改用项目目录打包并验证同一tarball通过,未删除系统数据。Ledger追加冲突前向修复保留两批记录,无强推或历史改写。原生Safari W3C click间歇无投递在MF-139保留限制,本次真实加载与状态检查分开。
阻断产品异常恢复前述已验证生产部署,并追加回退记录。Self-review:规范合规与代码质量分别检查;自动化工具参与,不声称独立人工审查。
Note
Medium Risk
Touches core load/progress and startup UI ordering across browsers; scope is limited to the viewer with one indexed asset change and new tests, but regressions in Safari loading or poster timing would affect every scene open.
Overview
Viewer 5.21.11 improves initial LOD loading feedback, poster/loading UI ordering, official branding, and one Tribbie cover asset update.
Loading progress: When the splat octree exposes chunk file URLs, the bar now advances from per-chunk download progress (bytes received vs total), not only when whole chunks finish—addressing coarse jumps (e.g. Safari 0% → 14%). Progress stays monotone, caps at 99% until the scene is ready, and ignores unknown totals, retries, and cancellations as completions.
Poster readiness: New
posterflow hides non-poster UI while the cover is pending, reveals chrome after load/cache plus a paint frame, and degrades on error or 10s timeout without blocking the first scene frame. Loading details can show a localized “preview unavailable” line.Branding: Collapsed logo uses inlined
metaflow_logo.svg; hover/focus/touch expands to the fullmetaflow.svglockup with width/opacity transitions. Build inlines SVG via Rollup HTML tokens; touch uses first tap to expand, second to follow the home link.Data/release: Version mirrors and ledger document MF-142. Only Tribbie (
/acg/szcaf15/honkai_star_rail-tribbie) changes: thumbnail →cover-4096-q82.webp(~361 KB q82 WebP at 4096²). Other 99 resources unchanged.Tests/docs: Added unit tests for poster behavior and streaming progress; verification ledger for 5.21.11.
Reviewed by Cursor Bugbot for commit 4df2894. Bugbot is set up for automated code reviews on this repo. Configure here.