Skip to content

feat: Avoid using display-buffer-overriding-action with ghostel - #265

Closed
djr7C4 wants to merge 1 commit into
Silex:mainfrom
djr7C4:no-display-override
Closed

djr7C4 wants to merge 1 commit into
Silex:mainfrom
djr7C4:no-display-override

Conversation

@djr7C4

@djr7C4 djr7C4 commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Using display-buffer-overriding-action breaks other-window-prefix and
same-window-prefix. A simpler solution is to use
(pop-to-buffer (ghostel-create)).

display-buffer-overriding-action breaks other-window-prefix and
same-window-prefix. A simpler solution is to
use (pop-to-buffer (ghostel-create)).
@Silex

Silex commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Thanks! I imported your commit, with your authorship, on the next branch, which will be merged to main soon. I adapted it on the way: it checks for ghostel-create (ghostel 0.52.0 or later) after requiring ghostel, since that function is not autoloaded, and it passes the pop-up window as ghostel-create's display action so the terminal is sized to the window that shows it, while other-window-prefix and same-window-prefix still win.

@Silex Silex closed this Sep 30, 2026
@djr7C4

djr7C4 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

Sounds good. I'll look forward to seeing it once it's merged. The next branch seems to be local only.

@Silex

Silex commented Sep 30, 2026

Copy link
Copy Markdown
Owner

It's on main 🎉

Will cut 2.6.0 soonish after a few more fixes and maybe feedback from users if smth breaks.

@djr7C4

djr7C4 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

Nice. I'm checking out the new features. Maybe add a 2.6.0 tag if you like.

@djr7C4

djr7C4 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

Oh, nvm. For some reason I was thinking this was already 2.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants