feat: support pods that are owned by deployments#22
Conversation
Signed-off-by: Charlie Getzen <charliegetzen@meshy.ai>
Signed-off-by: Charlie Getzen <charliegetzen@meshy.ai>
|
Good morning @cgetzen, Despite the example in the documentation, at this time Slurm-bridge does not support the scheduling of Deployments. I am tracking an issue internally to enable this capability, though it will take some time, as it will require changes to Slurm itself. In the meantime, I will try to get that example in the docs fixed. Best, |
|
Appreciate the review. We've been scheduling Deployments' pods for a few months (though we've granted permissions by creating additional clusterRoles and clusterRoleBindings instead of changing the chart, in order reduce divergence from upstream) and have not encountered issues related to pods being owned by Deployments. I will be looking out for the changes in slurm to see what we missed. Thanks! |
|
It may be worth considering how slurm-bridge handles 3rd party pod controllers. Right now, my org is adding arbitrary permissions like: Maybe slurm-bridge should still schedule pods even when it doesn't have permission to walk the ownership tree. |
Summary
Resolves #21
The deployment example in https://github.com/SlinkyProject/slurm-bridge/blob/main/docs/workload.md#annotations does not work.
Given that Pod is a supported workload, pods owned by deployments should also be supported.
Checklist
CONTRIBUTING.md
and the
Code of Conduct.
Breaking Changes
No breaking changes
Testing Notes
Integration tests have been added for the scheduler, similar to controller and admissions integration tests.
Applying the example from the readme now schedules correctly:
Additional Context